Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: chrome/browser/ui/views/profiles/profile_chooser_view.cc

Issue 2251343005: [User menu] Manually close the user menu upon signin modals (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/profiles/profile_chooser_view.cc
diff --git a/chrome/browser/ui/views/profiles/profile_chooser_view.cc b/chrome/browser/ui/views/profiles/profile_chooser_view.cc
index 9aa06e8b731cb147e8946c99c873675f4797d8db..c6670a2d0cc05b3d295605f38b4563c4724ef728 100644
--- a/chrome/browser/ui/views/profiles/profile_chooser_view.cc
+++ b/chrome/browser/ui/views/profiles/profile_chooser_view.cc
@@ -954,6 +954,10 @@ void ProfileChooserView::ShowView(profiles::BubbleViewMode view_to_display,
void ProfileChooserView::ShowViewFromMode(profiles::BubbleViewMode mode) {
if (SigninViewController::ShouldShowModalSigninForMode(mode)) {
+ // Hides the user menu if it is currently shown. The user menu automatically
+ // closes when it loses focus; however, on Windows, the signin modals do not
+ // take away focus, thus we need to manually close the bubble.
+ Hide();
browser_->ShowModalSigninWindow(mode, access_point_);
} else {
ShowView(mode, avatar_menu_.get());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698