Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2251343005: [User menu] Manually close the user menu upon signin modals (Closed)

Created:
4 years, 4 months ago by Jane
Modified:
4 years, 4 months ago
Reviewers:
*sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[User menu] Manually close the user menu upon signin modals Manually close the user menu when signin tab modals get triggered from the user menu, because signin modals don't take away focus on windows. BUG=615893 Committed: https://crrev.com/5c1b94967e6c785c92201266d539fe805ad9d0fe Cr-Commit-Position: refs/heads/master@{#413271}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Jane
Thanks!
4 years, 4 months ago (2016-08-19 19:46:17 UTC) #3
sky
LGTM
4 years, 4 months ago (2016-08-19 20:08:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2251343005/1
4 years, 4 months ago (2016-08-19 22:37:07 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-19 22:42:45 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 22:44:58 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c1b94967e6c785c92201266d539fe805ad9d0fe
Cr-Commit-Position: refs/heads/master@{#413271}

Powered by Google App Engine
This is Rietveld 408576698