third_party/WebKit/Source/platform/v8_inspector/V8DebuggerScript.cpp - Issue 2251343003: [DevTools] Generate separate copies of inspector_protocol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerScript.cpp

Issue 2251343003: [DevTools] Generate separate copies of inspector_protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/v8_inspector/String16.cpp ('K') | « third_party/WebKit/Source/platform/v8_inspector/V8DebuggerScript.h ('k') | third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerScript.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerScript.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerScript.cpp

index 76e0c0066bfb891bdc8191652d5ece90a207042b..f2e38d7cbffa238c16b6943b88fdbf6ebe93c06b 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerScript.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerScript.cpp

@@ -4,7 +4,8 @@

#include "platform/v8_inspector/V8DebuggerScript.h"

-#include "platform/v8_inspector/V8StringUtil.h"

+#include "platform/v8_inspector/ProtocolPlatform.h"

+#include "platform/v8_inspector/StringUtil.h"

namespace v8_inspector {

@@ -31,7 +32,7 @@ static String16 calculateHash(const String16& str)

uint64_t hashes[] = { 0, 0, 0, 0, 0 };

uint64_t zi[] = { 1, 1, 1, 1, 1 };

- const size_t hashesSize = PROTOCOL_ARRAY_LENGTH(hashes);

+ const size_t hashesSize = V8_INSPECTOR_ARRAY_LENGTH(hashes);

caseq 2016/08/26 19:17:20 nit: I'd get rid of these in favor of std::end(has

dgozman 2016/08/26 21:31:27 We can do that in a follow up.

size_t current = 0;

const uint32_t* data = nullptr;