third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp - Issue 2251343003: [DevTools] Generate separate copies of inspector_protocol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp

Issue 2251343003: [DevTools] Generate separate copies of inspector_protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: improvements Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/v8_inspector/SearchUtil.cpp ('K') | « third_party/WebKit/Source/platform/v8_inspector/V8Console.h ('k') | third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp

index 13f741756c37a37cd206acbdbd4471c41f64950f..1020d159641b8f69617544943758a588932247da 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp

@@ -6,6 +6,7 @@

#include "platform/v8_inspector/InjectedScript.h"

#include "platform/v8_inspector/InspectedContext.h"

+#include "platform/v8_inspector/StringUtil.h"

#include "platform/v8_inspector/V8Compat.h"

#include "platform/v8_inspector/V8ConsoleMessage.h"

#include "platform/v8_inspector/V8DebuggerAgentImpl.h"

@@ -14,7 +15,6 @@

#include "platform/v8_inspector/V8ProfilerAgentImpl.h"

#include "platform/v8_inspector/V8RuntimeAgentImpl.h"

#include "platform/v8_inspector/V8StackTraceImpl.h"

-#include "platform/v8_inspector/V8StringUtil.h"

#include "platform/v8_inspector/public/V8InspectorClient.h"

namespace v8_inspector {

@@ -27,7 +27,7 @@ v8::Local<v8::Private> inspectedContextPrivateKey(v8::Isolate* isolate)

}

class ConsoleHelper {

- PROTOCOL_DISALLOW_COPY(ConsoleHelper);

+ V8_INSPECTOR_DISALLOW_COPY(ConsoleHelper);

public:

ConsoleHelper(const v8::FunctionCallbackInfo<v8::Value>& info)

: m_info(info)