third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h - Issue 2251343003: [DevTools] Generate separate copies of inspector_protocol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h

Issue 2251343003: [DevTools] Generate separate copies of inspector_protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: win compile Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h ('k') | third_party/WebKit/Source/platform/v8_inspector/v8_inspector.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h b/third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h

index a7f9b669058a16be18abc45475245002a339df5a..82b6357f5e606461bbbb975586ccf5637676ca65 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h

@@ -9,8 +9,6 @@

#include "platform/v8_inspector/public/StringView.h"

#include "platform/v8_inspector/public/protocol/Runtime.h"

-#include <v8.h>

namespace v8_inspector {

class V8StackTrace {

@@ -23,7 +21,7 @@ public:

virtual StringView topFunctionName() const = 0;

virtual ~V8StackTrace() { }

- virtual std::unique_ptr<blink::protocol::Runtime::API::StackTrace> buildInspectorObject() const = 0;

+ virtual std::unique_ptr<protocol::Runtime::API::StackTrace> buildInspectorObject() const = 0;

virtual std::unique_ptr<StringBuffer> toString() const = 0;

// Safe to pass between threads, drops async chain.