Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp

Issue 2251343003: [DevTools] Generate separate copies of inspector_protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: win compile Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp
index 8f7c5a6c0cf110ad9722f29285ff2c60d3b8fed2..e06cad47dee18ae6d18848a73976802d69648c8d 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp
@@ -4,8 +4,9 @@
#include "platform/v8_inspector/V8StackTraceImpl.h"
+#include "platform/v8_inspector/StringUtil.h"
#include "platform/v8_inspector/V8Debugger.h"
-#include "platform/v8_inspector/V8StringUtil.h"
+#include "platform/v8_inspector/protocol/Protocol.h"
#include <v8-debug.h>
#include <v8-profiler.h>
@@ -93,7 +94,7 @@ std::unique_ptr<protocol::Runtime::CallFrame> V8StackTraceImpl::Frame::buildInsp
V8StackTraceImpl::Frame V8StackTraceImpl::Frame::clone() const
{
- return Frame(m_functionName.isolatedCopy(), m_scriptId.isolatedCopy(), m_scriptName.isolatedCopy(), m_lineNumber, m_columnNumber);
+ return Frame(m_functionName, m_scriptId, m_scriptName, m_lineNumber, m_columnNumber);
}
// static
@@ -170,7 +171,7 @@ std::unique_ptr<V8StackTrace> V8StackTraceImpl::clone()
std::vector<Frame> frames;
for (size_t i = 0; i < m_frames.size(); i++)
frames.push_back(m_frames.at(i).clone());
- return wrapUnique(new V8StackTraceImpl(m_contextGroupId, m_description.isolatedCopy(), frames, nullptr));
+ return wrapUnique(new V8StackTraceImpl(m_contextGroupId, m_description, frames, nullptr));
}
V8StackTraceImpl::V8StackTraceImpl(int contextGroupId, const String16& description, std::vector<Frame>& frames, std::unique_ptr<V8StackTraceImpl> parent)

Powered by Google App Engine
This is Rietveld 408576698