Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.h

Issue 2251343003: [DevTools] Generate separate copies of inspector_protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: win compile Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.h
index a363bae286a23fdd66ff3c3204ad541cc8fa3dc9..a6aeec6c629d1f7a74f1d056f8721798c212e156 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.h
@@ -31,7 +31,8 @@
#ifndef V8InspectorImpl_h
#define V8InspectorImpl_h
-#include "platform/inspector_protocol/InspectorProtocol.h"
+#include "platform/v8_inspector/Allocator.h"
+#include "platform/v8_inspector/protocol/Protocol.h"
#include "platform/v8_inspector/public/V8Inspector.h"
#include <v8-debug.h>
@@ -48,10 +49,8 @@ class V8InspectorSessionImpl;
class V8RuntimeAgentImpl;
class V8StackTraceImpl;
-namespace protocol = blink::protocol;
-
class V8InspectorImpl : public V8Inspector {
- PROTOCOL_DISALLOW_COPY(V8InspectorImpl);
+ V8_INSPECTOR_DISALLOW_COPY(V8InspectorImpl);
public:
V8InspectorImpl(v8::Isolate*, V8InspectorClient*);
~V8InspectorImpl() override;
@@ -67,7 +66,7 @@ public:
v8::Local<v8::Context> regexContext();
// V8Inspector implementation.
- std::unique_ptr<V8InspectorSession> connect(int contextGroupId, protocol::FrontendChannel*, const StringView& state) override;
+ std::unique_ptr<V8InspectorSession> connect(int contextGroupId, V8Inspector::Channel*, const StringView& state) override;
void contextCreated(const V8ContextInfo&) override;
void contextDestroyed(v8::Local<v8::Context>) override;
void resetContextGroup(int contextGroupId) override;

Powered by Google App Engine
This is Rietveld 408576698