third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.h - Issue 2251343003: [DevTools] Generate separate copies of inspector_protocol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.h

Issue 2251343003: [DevTools] Generate separate copies of inspector_protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: win compile Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.h

index 198772a4836a4ca7c7298c555c7c7c8ed19eeac7..e606c9008c348abd1712c209d5b6cbc490d40023 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.h

@@ -5,7 +5,8 @@

#ifndef V8HeapProfilerAgentImpl_h

#define V8HeapProfilerAgentImpl_h

-#include "platform/inspector_protocol/InspectorProtocol.h"

+#include "platform/v8_inspector/Allocator.h"

+#include "platform/v8_inspector/protocol/Forward.h"

#include "platform/v8_inspector/protocol/HeapProfiler.h"

#include <v8.h>

@@ -14,11 +15,11 @@ namespace v8_inspector {

class V8InspectorSessionImpl;

-namespace protocol = blink::protocol;

-using blink::protocol::Maybe;

+using protocol::ErrorString;

+using protocol::Maybe;

class V8HeapProfilerAgentImpl : public protocol::HeapProfiler::Backend {

- PROTOCOL_DISALLOW_COPY(V8HeapProfilerAgentImpl);

+ V8_INSPECTOR_DISALLOW_COPY(V8HeapProfilerAgentImpl);

public:

V8HeapProfilerAgentImpl(V8InspectorSessionImpl*, protocol::FrontendChannel*, protocol::DictionaryValue* state);

~V8HeapProfilerAgentImpl() override;