third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h - Issue 2251343003: [DevTools] Generate separate copies of inspector_protocol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h

Issue 2251343003: [DevTools] Generate separate copies of inspector_protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/v8_inspector/String16.cpp ('K') | « third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorClient.h ('k') | third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h b/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h

index b0c980f72df2724c49d702230ab8e020c42c10a6..02b52c2a80f368ac154558526d0ecb969a14298e 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h

@@ -5,7 +5,7 @@

#ifndef V8InspectorSession_h

#define V8InspectorSession_h

-#include "platform/inspector_protocol/InspectorProtocol.h"

+#include "platform/v8_inspector/String16.h"

#include "platform/v8_inspector/public/protocol/Debugger.h"

#include "platform/v8_inspector/public/protocol/Runtime.h"

@@ -37,11 +37,11 @@ public:

virtual void setSkipAllPauses(bool) = 0;

virtual void resume() = 0;

virtual void stepOver() = 0;

- virtual std::unique_ptr<blink::protocol::Array<blink::protocol::Debugger::API::SearchMatch>> searchInTextByLines(const String16& text, const String16& query, bool caseSensitive, bool isRegex) = 0;

+ virtual std::vector<std::unique_ptr<protocol::Debugger::API::SearchMatch>> searchInTextByLines(const String16& text, const String16& query, bool caseSensitive, bool isRegex) = 0;

// Remote objects.

- virtual std::unique_ptr<blink::protocol::Runtime::API::RemoteObject> wrapObject(v8::Local<v8::Context>, v8::Local<v8::Value>, const String16& groupName) = 0;

- virtual bool unwrapObject(ErrorString*, const String16& objectId, v8::Local<v8::Value>*, v8::Local<v8::Context>*, String16* objectGroup) = 0;

+ virtual std::unique_ptr<protocol::Runtime::API::RemoteObject> wrapObject(v8::Local<v8::Context>, v8::Local<v8::Value>, const String16& groupName) = 0;

+ virtual bool unwrapObject(String16* errorString, const String16& objectId, v8::Local<v8::Value>*, v8::Local<v8::Context>*, String16* objectGroup) = 0;

virtual void releaseObjectGroup(const String16&) = 0;

};