third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp - Issue 2251343003: [DevTools] Generate separate copies of inspector_protocol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp

Issue 2251343003: [DevTools] Generate separate copies of inspector_protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/v8_inspector/String16.cpp ('K') | « third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h ('k') | third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp

index e0bab17d89084f086fb7987bf9f4d65a61e76453..70566e031f76c1ec1c1d03f5769fec696a3b8113 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp

@@ -93,7 +93,7 @@ std::unique_ptr<protocol::Runtime::CallFrame> V8StackTraceImpl::Frame::buildInsp

V8StackTraceImpl::Frame V8StackTraceImpl::Frame::clone() const

{

- return Frame(m_functionName.isolatedCopy(), m_scriptId.isolatedCopy(), m_scriptName.isolatedCopy(), m_lineNumber, m_columnNumber);

+ return Frame(m_functionName, m_scriptId, m_scriptName, m_lineNumber, m_columnNumber);

}

// static

@@ -170,7 +170,7 @@ std::unique_ptr<V8StackTrace> V8StackTraceImpl::clone()

std::vector<Frame> frames;

for (size_t i = 0; i < m_frames.size(); i++)

frames.push_back(m_frames.at(i).clone());

- return wrapUnique(new V8StackTraceImpl(m_contextGroupId, m_description.isolatedCopy(), frames, nullptr));

+ return wrapUnique(new V8StackTraceImpl(m_contextGroupId, m_description, frames, nullptr));

}

V8StackTraceImpl::V8StackTraceImpl(int contextGroupId, const String16& description, std::vector<Frame>& frames, std::unique_ptr<V8StackTraceImpl> parent)