third_party/WebKit/Source/bindings/core/v8/SourceLocation.h - Issue 2251343003: [DevTools] Generate separate copies of inspector_protocol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/SourceLocation.h

Issue 2251343003: [DevTools] Generate separate copies of inspector_protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/SourceLocation.cpp » ('j') | third_party/WebKit/Source/bindings/core/v8/SourceLocation.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/SourceLocation.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/SourceLocation.h b/third_party/WebKit/Source/bindings/core/v8/SourceLocation.h

index 106d6c8628776a99cc5484dd8b5d27c4acf6d6f2..f24974127212a23e0fd0faf4edcd81cf5167c0f0 100644

--- a/third_party/WebKit/Source/bindings/core/v8/SourceLocation.h

+++ b/third_party/WebKit/Source/bindings/core/v8/SourceLocation.h

@@ -51,7 +51,7 @@ public:

String toString() const;

// Could be null when stack trace is unknown.

- std::unique_ptr<protocol::Runtime::API::StackTrace> buildInspectorObject() const;

+ std::unique_ptr<v8_inspector::protocol::Runtime::API::StackTrace> buildInspectorObject() const;

private:

SourceLocation(const String& url, unsigned lineNumber, unsigned columnNumber, std::unique_ptr<v8_inspector::V8StackTrace>, int scriptId);