Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Side by Side Diff: third_party/WebKit/Source/platform/v8_inspector/V8Regex.cpp

Issue 2251343003: [DevTools] Generate separate copies of inspector_protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: win compile Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/v8_inspector/V8Regex.h" 5 #include "platform/v8_inspector/V8Regex.h"
6 6
7 #include "platform/v8_inspector/StringUtil.h"
7 #include "platform/v8_inspector/V8Compat.h" 8 #include "platform/v8_inspector/V8Compat.h"
8 #include "platform/v8_inspector/V8InspectorImpl.h" 9 #include "platform/v8_inspector/V8InspectorImpl.h"
9 #include "platform/v8_inspector/V8StringUtil.h"
10 #include "platform/v8_inspector/public/V8InspectorClient.h" 10 #include "platform/v8_inspector/public/V8InspectorClient.h"
11 11
12 #include <limits.h> 12 #include <limits.h>
13 13
14 namespace v8_inspector { 14 namespace v8_inspector {
15 15
16 V8Regex::V8Regex(V8InspectorImpl* inspector, const String16& pattern, bool caseS ensitive, bool multiline) 16 V8Regex::V8Regex(V8InspectorImpl* inspector, const String16& pattern, bool caseS ensitive, bool multiline)
17 : m_inspector(inspector) 17 : m_inspector(inspector)
18 { 18 {
19 v8::Isolate* isolate = m_inspector->isolate(); 19 v8::Isolate* isolate = m_inspector->isolate();
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 v8::Local<v8::Context> context = m_inspector->regexContext(); 54 v8::Local<v8::Context> context = m_inspector->regexContext();
55 v8::MicrotasksScope microtasks(isolate, v8::MicrotasksScope::kDoNotRunMicrot asks); 55 v8::MicrotasksScope microtasks(isolate, v8::MicrotasksScope::kDoNotRunMicrot asks);
56 v8::TryCatch tryCatch(isolate); 56 v8::TryCatch tryCatch(isolate);
57 57
58 v8::Local<v8::RegExp> regex = m_regex.Get(isolate); 58 v8::Local<v8::RegExp> regex = m_regex.Get(isolate);
59 v8::Local<v8::Value> exec; 59 v8::Local<v8::Value> exec;
60 if (!regex->Get(context, toV8StringInternalized(isolate, "exec")).ToLocal(&e xec)) 60 if (!regex->Get(context, toV8StringInternalized(isolate, "exec")).ToLocal(&e xec))
61 return -1; 61 return -1;
62 v8::Local<v8::Value> argv[] = { toV8String(isolate, string.substring(startFr om)) }; 62 v8::Local<v8::Value> argv[] = { toV8String(isolate, string.substring(startFr om)) };
63 v8::Local<v8::Value> returnValue; 63 v8::Local<v8::Value> returnValue;
64 if (!exec.As<v8::Function>()->Call(context, regex, PROTOCOL_ARRAY_LENGTH(arg v), argv).ToLocal(&returnValue)) 64 if (!exec.As<v8::Function>()->Call(context, regex, V8_INSPECTOR_ARRAY_LENGTH (argv), argv).ToLocal(&returnValue))
65 return -1; 65 return -1;
66 66
67 // RegExp#exec returns null if there's no match, otherwise it returns an 67 // RegExp#exec returns null if there's no match, otherwise it returns an
68 // Array of strings with the first being the whole match string and others 68 // Array of strings with the first being the whole match string and others
69 // being subgroups. The Array also has some random properties tacked on like 69 // being subgroups. The Array also has some random properties tacked on like
70 // "index" which is the offset of the match. 70 // "index" which is the offset of the match.
71 // 71 //
72 // https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Global_Obje cts/RegExp/exec 72 // https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Global_Obje cts/RegExp/exec
73 73
74 DCHECK(!returnValue.IsEmpty()); 74 DCHECK(!returnValue.IsEmpty());
75 if (!returnValue->IsArray()) 75 if (!returnValue->IsArray())
76 return -1; 76 return -1;
77 77
78 v8::Local<v8::Array> result = returnValue.As<v8::Array>(); 78 v8::Local<v8::Array> result = returnValue.As<v8::Array>();
79 v8::Local<v8::Value> matchOffset; 79 v8::Local<v8::Value> matchOffset;
80 if (!result->Get(context, toV8StringInternalized(isolate, "index")).ToLocal( &matchOffset)) 80 if (!result->Get(context, toV8StringInternalized(isolate, "index")).ToLocal( &matchOffset))
81 return -1; 81 return -1;
82 if (matchLength) { 82 if (matchLength) {
83 v8::Local<v8::Value> match; 83 v8::Local<v8::Value> match;
84 if (!result->Get(context, 0).ToLocal(&match)) 84 if (!result->Get(context, 0).ToLocal(&match))
85 return -1; 85 return -1;
86 *matchLength = match.As<v8::String>()->Length(); 86 *matchLength = match.As<v8::String>()->Length();
87 } 87 }
88 88
89 return matchOffset.As<v8::Int32>()->Value() + startFrom; 89 return matchOffset.As<v8::Int32>()->Value() + startFrom;
90 } 90 }
91 91
92 } // namespace v8_inspector 92 } // namespace v8_inspector
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698