[DevTools] Generate separate copies of inspector_protocol.

third_party/WebKit/Source/bindings/core/v8/SourceLocation.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "bindings/core/v8/SourceLocation.h"
 
 #include "bindings/core/v8/V8BindingMacros.h"
 #include "bindings/core/v8/V8PerIsolateData.h"
 #include "core/dom/Document.h"
 #include "core/dom/ExecutionContext.h"
 #include "core/dom/ScriptableDocumentParser.h"
 #include "core/html/HTMLFrameOwnerElement.h"
 #include "core/inspector/ThreadDebugger.h"
+#include "core/inspector/V8InspectorStringConversion.h"
 #include "platform/ScriptForbiddenScope.h"
 #include "platform/TracedValue.h"
 #include "platform/v8_inspector/public/V8Inspector.h"
 #include "wtf/PtrUtil.h"
 #include <memory>
 
 namespace blink {
 
 namespace {
 
@@ skipping 72 matching lines @@
 // static
 std::unique_ptr<SourceLocation> SourceLocation::create(const String& url, unsigned lineNumber, unsigned columnNumber, std::unique_ptr<v8_inspector::V8StackTrace> stackTrace, int scriptId)
 {
     return wrapUnique(new SourceLocation(url, lineNumber, columnNumber, std::move(stackTrace), scriptId));
 }
 
 // static
 std::unique_ptr<SourceLocation> SourceLocation::createFromNonEmptyV8StackTrace(std::unique_ptr<v8_inspector::V8StackTrace> stackTrace, int scriptId)
 {
     // Retrieve the data before passing the ownership to SourceLocation.
-    const String& url = stackTrace->topSourceURL();
+    const String& url = toCoreString(stackTrace->topSourceURL());

[caseq, 2016/08/19 02:50:36]

this doesn't look good :-)

     unsigned lineNumber = stackTrace->topLineNumber();
     unsigned columnNumber = stackTrace->topColumnNumber();
     return wrapUnique(new SourceLocation(url, lineNumber, columnNumber, std::move(stackTrace), scriptId));
 }
 
 // static
 std::unique_ptr<SourceLocation> SourceLocation::fromFunction(v8::Local<v8::Function> function)
 {
     if (!function.IsEmpty())
         return SourceLocation::create(toCoreStringWithUndefinedOrNullCheck(function->GetScriptOrigin().ResourceName()), function->GetScriptLineNumber() + 1, function->GetScriptColumnNumber() + 1, nullptr, function->ScriptId());
@@ skipping 21 matching lines @@
 SourceLocation::~SourceLocation()
 {
 }
 
 void SourceLocation::toTracedValue(TracedValue* value, const char* name) const
 {
     if (!m_stackTrace || m_stackTrace->isEmpty())
         return;
     value->beginArray(name);
     value->beginDictionary();
-    value->setString("functionName", m_stackTrace->topFunctionName());
-    value->setString("scriptId", m_stackTrace->topScriptId());
-    value->setString("url", m_stackTrace->topSourceURL());
+    value->setString("functionName", toCoreString(m_stackTrace->topFunctionName()));
+    value->setString("scriptId", toCoreString(m_stackTrace->topScriptId()));
+    value->setString("url", toCoreString(m_stackTrace->topSourceURL()));
     value->setInteger("lineNumber", m_stackTrace->topLineNumber());
     value->setInteger("columnNumber", m_stackTrace->topColumnNumber());
     value->endDictionary();
     value->endArray();
 }
 
 std::unique_ptr<SourceLocation> SourceLocation::clone() const
 {
     return wrapUnique(new SourceLocation(m_url.isolatedCopy(), m_lineNumber, m_columnNumber, m_stackTrace ? m_stackTrace->clone() : nullptr, m_scriptId));
 }
 
-std::unique_ptr<protocol::Runtime::API::StackTrace> SourceLocation::buildInspectorObject() const
+std::unique_ptr<v8_inspector::protocol::Runtime::API::StackTrace> SourceLocation::buildInspectorObject() const
 {
     return m_stackTrace ? m_stackTrace->buildInspectorObject() : nullptr;
 }
 
 String SourceLocation::toString() const
 {
     if (!m_stackTrace)
         return String();
-    return m_stackTrace->toString();
+    return toCoreString(m_stackTrace->toString());
 }
 
 } // namespace blink