Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: fpdfsdk/javascript/app.h

Issue 2251333002: Use a map for app::m_Timers (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Review feedback Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | fpdfsdk/javascript/app.cpp » ('j') | fpdfsdk/javascript/app.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #ifndef FPDFSDK_JAVASCRIPT_APP_H_ 7 #ifndef FPDFSDK_JAVASCRIPT_APP_H_
8 #define FPDFSDK_JAVASCRIPT_APP_H_ 8 #define FPDFSDK_JAVASCRIPT_APP_H_
9 9
10 #include <map>
10 #include <memory> 11 #include <memory>
11 #include <vector> 12 #include <vector>
12 13
13 #include "fpdfsdk/javascript/JS_Define.h" 14 #include "fpdfsdk/javascript/JS_Define.h"
14 15
15 class CJS_Runtime; 16 class CJS_Runtime;
16 class GlobalTimer; 17 class GlobalTimer;
17 18
18 class TimerObj : public CJS_EmbedObj { 19 class TimerObj : public CJS_EmbedObj {
19 public: 20 public:
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 static CFX_WideString SysPathToPDFPath(const CFX_WideString& sOldPath); 159 static CFX_WideString SysPathToPDFPath(const CFX_WideString& sOldPath);
159 160
160 private: 161 private:
161 // CJS_EmbedObj 162 // CJS_EmbedObj
162 void RunJsScript(CJS_Runtime* pRuntime, const CFX_WideString& wsScript); 163 void RunJsScript(CJS_Runtime* pRuntime, const CFX_WideString& wsScript);
163 164
164 void ClearTimerCommon(CJS_Runtime* pRuntime, const CJS_Value& param); 165 void ClearTimerCommon(CJS_Runtime* pRuntime, const CJS_Value& param);
165 166
166 bool m_bCalculate; 167 bool m_bCalculate;
167 bool m_bRuntimeHighLight; 168 bool m_bRuntimeHighLight;
168 std::vector<std::unique_ptr<GlobalTimer>> m_Timers; 169 std::map<GlobalTimer*, std::unique_ptr<GlobalTimer>> m_Timers;
169 }; 170 };
170 171
171 class CJS_App : public CJS_Object { 172 class CJS_App : public CJS_Object {
172 public: 173 public:
173 explicit CJS_App(v8::Local<v8::Object> pObject) : CJS_Object(pObject) {} 174 explicit CJS_App(v8::Local<v8::Object> pObject) : CJS_Object(pObject) {}
174 ~CJS_App() override {} 175 ~CJS_App() override {}
175 176
176 DECLARE_JS_CLASS(); 177 DECLARE_JS_CLASS();
177 178
178 JS_STATIC_PROP(activeDocs, app); 179 JS_STATIC_PROP(activeDocs, app);
(...skipping 26 matching lines...) Expand all
205 JS_STATIC_METHOD(openDoc, app); 206 JS_STATIC_METHOD(openDoc, app);
206 JS_STATIC_METHOD(openFDF, app); 207 JS_STATIC_METHOD(openFDF, app);
207 JS_STATIC_METHOD(popUpMenuEx, app); 208 JS_STATIC_METHOD(popUpMenuEx, app);
208 JS_STATIC_METHOD(popUpMenu, app); 209 JS_STATIC_METHOD(popUpMenu, app);
209 JS_STATIC_METHOD(response, app); 210 JS_STATIC_METHOD(response, app);
210 JS_STATIC_METHOD(setInterval, app); 211 JS_STATIC_METHOD(setInterval, app);
211 JS_STATIC_METHOD(setTimeOut, app); 212 JS_STATIC_METHOD(setTimeOut, app);
212 }; 213 };
213 214
214 #endif // FPDFSDK_JAVASCRIPT_APP_H_ 215 #endif // FPDFSDK_JAVASCRIPT_APP_H_
OLDNEW
« no previous file with comments | « no previous file | fpdfsdk/javascript/app.cpp » ('j') | fpdfsdk/javascript/app.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698