Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2251313002: Revert of arc: Fix crash on Arc window close. (Closed)

Created:
4 years, 4 months ago by khmel
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Revert of arc: Fix crash on Arc window close. (patchset #1 id:1 of https://codereview.chromium.org/2252283002/ ) Reason for revert: Wrong resolve Original issue's description: > arc: Fix crash on Arc window close. > > BUG=638261 > BUG=b/30817552 > TEST=Manually on device. No more crashes are observed. > > NOTRY=true > NOPRESUBMIT=true > TBR=reviewer@chromium.org > > Review-Url: https://codereview.chromium.org/2251493002 > Cr-Commit-Position: refs/heads/master@{#412390} > (cherry picked from commit 323b4a4792b0c6eb7e51d2aee66773378229e486) TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=638261

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -108 lines) Patch
M chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.h View 3 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc View 4 chunks +41 lines, -66 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc View 4 chunks +1 line, -32 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
khmel
Created Revert of arc: Fix crash on Arc window close.
4 years, 4 months ago (2016-08-18 01:47:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2251313002/1
4 years, 4 months ago (2016-08-18 01:47:31 UTC) #3
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 01:53:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698