Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2991)

Unified Diff: cc/input/main_thread_scrolling_reason.h

Issue 2251303003: Implement position: sticky updates on compositor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge with master and add comments to WebLayerStickyPositionConstraint members. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/blink/web_layer_impl.cc ('k') | cc/layers/layer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/input/main_thread_scrolling_reason.h
diff --git a/cc/input/main_thread_scrolling_reason.h b/cc/input/main_thread_scrolling_reason.h
index 3695179c03545f46cf701571442fdc2290f1a529..2d45a4229645b6fa538768593c173027aca57b1a 100644
--- a/cc/input/main_thread_scrolling_reason.h
+++ b/cc/input/main_thread_scrolling_reason.h
@@ -28,7 +28,6 @@ struct MainThreadScrollingReason {
// animation. Note that a scroll handled by the main thread can result in an
// animation running on the main thread or on the compositor thread.
enum : uint32_t { kHandlingScrollFromMainThread = 1 << 13 };
- enum : uint32_t { kHasStickyPositionObjects = 1 << 14 };
enum : uint32_t { kCustomScrollbarScrolling = 1 << 15 };
// Transient scrolling reasons. These are computed for each scroll begin.
@@ -51,7 +50,7 @@ struct MainThreadScrollingReason {
kNotScrollingOnMain | kHasBackgroundAttachmentFixedObjects |
kHasNonLayerViewportConstrainedObjects | kThreadedScrollingDisabled |
kScrollbarScrolling | kPageOverlay | kHandlingScrollFromMainThread |
- kHasStickyPositionObjects | kCustomScrollbarScrolling;
+ kCustomScrollbarScrolling;
return (reasons & reasons_set_by_main_thread) == reasons;
}
@@ -94,8 +93,6 @@ struct MainThreadScrollingReason {
tracedValue->AppendString("Page overlay");
if (reasons & MainThreadScrollingReason::kHandlingScrollFromMainThread)
tracedValue->AppendString("Handling scroll from main thread");
- if (reasons & MainThreadScrollingReason::kHasStickyPositionObjects)
- tracedValue->AppendString("Has sticky position objects");
if (reasons & MainThreadScrollingReason::kCustomScrollbarScrolling)
tracedValue->AppendString("Custom scrollbar scrolling");
« no previous file with comments | « cc/blink/web_layer_impl.cc ('k') | cc/layers/layer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698