Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: cc/layers/layer_impl.h

Issue 2251303003: Implement position: sticky updates on compositor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cleanup and add unit test for impl side sticky position update. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2011 The Chromium Authors. All rights reserved. 1 // Copyright 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_LAYERS_LAYER_IMPL_H_ 5 #ifndef CC_LAYERS_LAYER_IMPL_H_
6 #define CC_LAYERS_LAYER_IMPL_H_ 6 #define CC_LAYERS_LAYER_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 217 matching lines...) Expand 10 before | Expand all | Expand 10 after
228 return use_parent_backface_visibility_; 228 return use_parent_backface_visibility_;
229 } 229 }
230 230
231 void SetUseLocalTransformForBackfaceVisibility(bool use_local) { 231 void SetUseLocalTransformForBackfaceVisibility(bool use_local) {
232 use_local_transform_for_backface_visibility_ = use_local; 232 use_local_transform_for_backface_visibility_ = use_local;
233 } 233 }
234 bool use_local_transform_for_backface_visibility() const { 234 bool use_local_transform_for_backface_visibility() const {
235 return use_local_transform_for_backface_visibility_; 235 return use_local_transform_for_backface_visibility_;
236 } 236 }
237 237
238 void SetStickyPositionConstraint(
239 const LayerStickyPositionConstraint& constraint) {
240 sticky_position_constraint_ = constraint;
241 }
242 const LayerStickyPositionConstraint& sticky_position_constraint() const {
243 return sticky_position_constraint_;
244 }
245
238 void SetShouldCheckBackfaceVisibility(bool should_check_backface_visibility) { 246 void SetShouldCheckBackfaceVisibility(bool should_check_backface_visibility) {
239 should_check_backface_visibility_ = should_check_backface_visibility; 247 should_check_backface_visibility_ = should_check_backface_visibility;
240 } 248 }
241 bool should_check_backface_visibility() const { 249 bool should_check_backface_visibility() const {
242 return should_check_backface_visibility_; 250 return should_check_backface_visibility_;
243 } 251 }
244 252
245 bool ShowDebugBorders() const; 253 bool ShowDebugBorders() const;
246 254
247 // These invalidate the host's render surface layer list. The caller 255 // These invalidate the host's render surface layer list. The caller
(...skipping 314 matching lines...) Expand 10 before | Expand all | Expand 10 after
562 570
563 // Denotes an area that is damaged and needs redraw. This is in the layer's 571 // Denotes an area that is damaged and needs redraw. This is in the layer's
564 // space. 572 // space.
565 gfx::Rect damage_rect_; 573 gfx::Rect damage_rect_;
566 574
567 // Group of properties that need to be computed based on the layer tree 575 // Group of properties that need to be computed based on the layer tree
568 // hierarchy before layers can be drawn. 576 // hierarchy before layers can be drawn.
569 DrawProperties draw_properties_; 577 DrawProperties draw_properties_;
570 PerformanceProperties<LayerImpl> performance_properties_; 578 PerformanceProperties<LayerImpl> performance_properties_;
571 579
580 LayerStickyPositionConstraint sticky_position_constraint_;
ajuma 2016/09/08 22:08:53 Does LayerImpl need to know this? Is it enough for
flackr 2016/09/20 17:08:12 Done.
581
572 std::unique_ptr<base::trace_event::ConvertableToTraceFormat> 582 std::unique_ptr<base::trace_event::ConvertableToTraceFormat>
573 owned_debug_info_; 583 owned_debug_info_;
574 base::trace_event::ConvertableToTraceFormat* debug_info_; 584 base::trace_event::ConvertableToTraceFormat* debug_info_;
575 std::unique_ptr<RenderSurfaceImpl> render_surface_; 585 std::unique_ptr<RenderSurfaceImpl> render_surface_;
576 586
577 bool scrolls_drawn_descendant_ : 1; 587 bool scrolls_drawn_descendant_ : 1;
578 bool has_will_change_transform_hint_ : 1; 588 bool has_will_change_transform_hint_ : 1;
579 bool needs_push_properties_ : 1; 589 bool needs_push_properties_ : 1;
580 590
581 DISALLOW_COPY_AND_ASSIGN(LayerImpl); 591 DISALLOW_COPY_AND_ASSIGN(LayerImpl);
582 }; 592 };
583 593
584 } // namespace cc 594 } // namespace cc
585 595
586 #endif // CC_LAYERS_LAYER_IMPL_H_ 596 #endif // CC_LAYERS_LAYER_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698