Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1759)

Unified Diff: chrome/browser/ui/webui/settings/search_engines_handler.cc

Issue 2251263003: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/search_engines_handler.cc
diff --git a/chrome/browser/ui/webui/settings/search_engines_handler.cc b/chrome/browser/ui/webui/settings/search_engines_handler.cc
index 36e57332a66284f3921c84a3581dd56cb9c2602f..fadcb3e025b7bd0e62d026df9d57b013fe3cd50f 100644
--- a/chrome/browser/ui/webui/settings/search_engines_handler.cc
+++ b/chrome/browser/ui/webui/settings/search_engines_handler.cc
@@ -102,7 +102,7 @@ SearchEnginesHandler::GetSearchEnginesList() {
// Build the first list (default search engines).
std::unique_ptr<base::ListValue> defaults =
- base::WrapUnique(new base::ListValue());
+ base::MakeUnique<base::ListValue>();
int last_default_engine_index =
list_controller_.table_model()->last_search_engine_index();
for (int i = 0; i < last_default_engine_index; ++i) {
@@ -111,8 +111,7 @@ SearchEnginesHandler::GetSearchEnginesList() {
}
// Build the second list (other search engines).
- std::unique_ptr<base::ListValue> others =
- base::WrapUnique(new base::ListValue());
+ std::unique_ptr<base::ListValue> others = base::MakeUnique<base::ListValue>();
int last_other_engine_index =
list_controller_.table_model()->last_other_engine_index();
for (int i = std::max(last_default_engine_index, 0);
@@ -122,7 +121,7 @@ SearchEnginesHandler::GetSearchEnginesList() {
// Build the third list (omnibox extensions).
std::unique_ptr<base::ListValue> extensions =
- base::WrapUnique(new base::ListValue());
+ base::MakeUnique<base::ListValue>();
int engine_count = list_controller_.table_model()->RowCount();
for (int i = std::max(last_other_engine_index, 0); i < engine_count; ++i) {
extensions->Append(CreateDictionaryForEngine(i, i == default_index));

Powered by Google App Engine
This is Rietveld 408576698