chrome/browser/ui/webui/settings/certificates_handler.cc - Issue 2251263003: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/certificates_handler.cc

Issue 2251263003: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/print_preview/extension_printer_handler_unittest.cc ('k') | chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/certificates_handler.cc

diff --git a/chrome/browser/ui/webui/settings/certificates_handler.cc b/chrome/browser/ui/webui/settings/certificates_handler.cc

index bc2e9ecc19b1d60fa1cf14b120449694594564bf..2bcc1b1b3013e3155991ca1def22b1f8278a03ca 100644

--- a/chrome/browser/ui/webui/settings/certificates_handler.cc

+++ b/chrome/browser/ui/webui/settings/certificates_handler.cc

@@ -1038,7 +1038,7 @@ void CertificatesHandler::PopulateTree(

{

std::unique_ptr<base::ListValue> nodes =

- base::WrapUnique(new base::ListValue());

+ base::MakeUnique<base::ListValue>();

for (CertificateManagerModel::OrgGroupingMap::iterator i = map.begin();

i != map.end(); ++i) {

// Populate first level (org name).

@@ -1125,7 +1125,7 @@ void CertificatesHandler::RejectCallbackWithImportError(

IDS_SETTINGS_CERTIFICATE_MANAGER_IMPORT_SOME_NOT_IMPORTED);

std::unique_ptr<base::ListValue> cert_error_list =

- base::WrapUnique(new base::ListValue());

+ base::MakeUnique<base::ListValue>();

for (size_t i = 0; i < not_imported.size(); ++i) {

const net::NSSCertDatabase::ImportCertFailure& failure = not_imported[i];

std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue);