chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc - Issue 2251263003: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc

Issue 2251263003: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/chromeos/login/base_screen_handler.cc ('k') | chrome/browser/ui/webui/omnibox/omnibox_page_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc

diff --git a/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc b/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc

index 5352c09f96cb8f2440d3306837dbb19df977daae..14347034b3929e0f421a71226a4a460ad8470f70 100644

--- a/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc

+++ b/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc

@@ -402,7 +402,7 @@ TEST_F(MediaRouterUITest, GetExtensionNameExtensionPresent) {

std::string id = "extensionid";

GURL url = GURL("chrome-extension://" + id);

std::unique_ptr<extensions::ExtensionRegistry> registry =

- base::WrapUnique(new extensions::ExtensionRegistry(nullptr));

+ base::MakeUnique<extensions::ExtensionRegistry>(nullptr);

scoped_refptr<extensions::Extension> app =

extensions::test_util::BuildApp(extensions::ExtensionBuilder())

.MergeManifest(extensions::DictionaryBuilder()

@@ -420,7 +420,7 @@ TEST_F(MediaRouterUITest, GetExtensionNameEmptyWhenNotInstalled) {

std::string id = "extensionid";

GURL url = GURL("chrome-extension://" + id);

std::unique_ptr<extensions::ExtensionRegistry> registry =

- base::WrapUnique(new extensions::ExtensionRegistry(nullptr));

+ base::MakeUnique<extensions::ExtensionRegistry>(nullptr);

EXPECT_EQ("", MediaRouterUI::GetExtensionName(url, registry.get()));

}

@@ -428,7 +428,7 @@ TEST_F(MediaRouterUITest, GetExtensionNameEmptyWhenNotInstalled) {

TEST_F(MediaRouterUITest, GetExtensionNameEmptyWhenNotExtensionURL) {

GURL url = GURL("https://www.google.com");

std::unique_ptr<extensions::ExtensionRegistry> registry =

- base::WrapUnique(new extensions::ExtensionRegistry(nullptr));

+ base::MakeUnique<extensions::ExtensionRegistry>(nullptr);

EXPECT_EQ("", MediaRouterUI::GetExtensionName(url, registry.get()));

}