chrome/browser/ui/app_list/test/fast_show_pickler_unittest.cc - Issue 2251263003: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/test/fast_show_pickler_unittest.cc

Issue 2251263003: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/app_list/search/search_resource_manager.cc ('k') | chrome/browser/ui/ash/app_list/app_list_service_ash.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/app_list/test/fast_show_pickler_unittest.cc

diff --git a/chrome/browser/ui/app_list/test/fast_show_pickler_unittest.cc b/chrome/browser/ui/app_list/test/fast_show_pickler_unittest.cc

index 21304ee2d66add3ead7151bc7da9546ef3e38177..159b55786d9e149946762b2c4ff8653d42a8888e 100644

--- a/chrome/browser/ui/app_list/test/fast_show_pickler_unittest.cc

+++ b/chrome/browser/ui/app_list/test/fast_show_pickler_unittest.cc

@@ -81,15 +81,15 @@ TEST_F(AppListModelPicklerUnitTest, EmptyModel) {

TEST_F(AppListModelPicklerUnitTest, OneItem) {

AppListModel model;

- model.AddItem(base::WrapUnique(new AppListItem("abc")));

+ model.AddItem(base::MakeUnique<AppListItem>("abc"));

DoConsistencyChecks(&model);

}

TEST_F(AppListModelPicklerUnitTest, TwoItems) {

AppListModel model;

- AppListItem* app1 = model.AddItem(base::WrapUnique(new AppListItem("abc")));

+ AppListItem* app1 = model.AddItem(base::MakeUnique<AppListItem>("abc"));

model.SetItemNameAndShortName(app1, "hello, there", "ht");

- AppListItem* app2 = model.AddItem(base::WrapUnique(new AppListItem("abc2")));

+ AppListItem* app2 = model.AddItem(base::MakeUnique<AppListItem>("abc2"));

model.SetItemNameAndShortName(app2, "hello, there 2", "ht2");

DoConsistencyChecks(&model);

@@ -97,10 +97,10 @@ TEST_F(AppListModelPicklerUnitTest, TwoItems) {

TEST_F(AppListModelPicklerUnitTest, Images) {

AppListModel model;

- AppListItem* app1 = model.AddItem(base::WrapUnique(new AppListItem("abc")));

+ AppListItem* app1 = model.AddItem(base::MakeUnique<AppListItem>("abc"));

model.SetItemName(app1, "hello, there");

app1->SetIcon(MakeImage());

- AppListItem* app2 = model.AddItem(base::WrapUnique(new AppListItem("abc2")));

+ AppListItem* app2 = model.AddItem(base::MakeUnique<AppListItem>("abc2"));

model.SetItemName(app2, "hello, there 2");

DoConsistencyChecks(&model);

@@ -108,7 +108,7 @@ TEST_F(AppListModelPicklerUnitTest, Images) {

TEST_F(AppListModelPicklerUnitTest, EmptyImage) {

AppListModel model;

- AppListItem* app1 = model.AddItem(base::WrapUnique(new AppListItem("abc")));

+ AppListItem* app1 = model.AddItem(base::MakeUnique<AppListItem>("abc"));

model.SetItemName(app1, "hello, there");

app1->SetIcon(gfx::ImageSkia());