chrome/browser/ui/app_list/search/launcher_search/launcher_search_icon_image_loader_unittest.cc - Issue 2251263003: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/search/launcher_search/launcher_search_icon_image_loader_unittest.cc

Issue 2251263003: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/app_list/launcher_page_event_dispatcher.cc ('k') | chrome/browser/ui/app_list/search/launcher_search/launcher_search_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/app_list/search/launcher_search/launcher_search_icon_image_loader_unittest.cc

diff --git a/chrome/browser/ui/app_list/search/launcher_search/launcher_search_icon_image_loader_unittest.cc b/chrome/browser/ui/app_list/search/launcher_search/launcher_search_icon_image_loader_unittest.cc

index a7d45ba642f8c86c3732266b55511126be4554b4..43f10fbf216b06129fb47740714bd271c727e746 100644

--- a/chrome/browser/ui/app_list/search/launcher_search/launcher_search_icon_image_loader_unittest.cc

+++ b/chrome/browser/ui/app_list/search/launcher_search/launcher_search_icon_image_loader_unittest.cc

@@ -98,7 +98,7 @@ class FakeErrorReporter : public ErrorReporter {

const std::string& GetLastWarningMessage() { return *last_message_.get(); }

std::unique_ptr<ErrorReporter> Duplicate() override {

- return base::WrapUnique(new FakeErrorReporter(last_message_));

+ return base::MakeUnique<FakeErrorReporter>(last_message_);

}

private:

@@ -136,7 +136,7 @@ class LauncherSearchIconImageLoaderTest : public testing::Test {

void SetUp() override { extension_ = CreateTestExtension(kTestExtensionId); }

std::unique_ptr<FakeErrorReporter> GetFakeErrorReporter() {

- return base::WrapUnique(new FakeErrorReporter());

+ return base::MakeUnique<FakeErrorReporter>();

}

scoped_refptr<extensions::Extension> extension_;