chrome/browser/ui/webui/omnibox/omnibox_page_handler.cc - Issue 2251263003: Re-write many calls to WrapUnique() with MakeUnique()

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/webui/omnibox/omnibox_page_handler.cc

Issue 2251263003: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc ('k') | chrome/browser/ui/webui/options/certificate_manager_browsertest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/webui/omnibox/omnibox_page_handler.h"	5 #include "chrome/browser/ui/webui/omnibox/omnibox_page_handler.h"

6	6

7 #include <stddef.h>	7 #include <stddef.h>

8	8

9 #include <string>	9 #include <string>

10 #include <utility>	10 #include <utility>

(...skipping 193 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
204 input_string.To<base::string16>(), cursor_position, std::string(), GURL(),	204 input_string.To<base::string16>(), cursor_position, std::string(), GURL(),

205 static_cast<metrics::OmniboxEventProto::PageClassification>(	205 static_cast<metrics::OmniboxEventProto::PageClassification>(

206 page_classification),	206 page_classification),

207 prevent_inline_autocomplete, prefer_keyword, true, true, false,	207 prevent_inline_autocomplete, prefer_keyword, true, true, false,

208 ChromeAutocompleteSchemeClassifier(profile_));	208 ChromeAutocompleteSchemeClassifier(profile_));

209 controller_->Start(input_);	209 controller_->Start(input_);

210 }	210 }

211	211

212 void OmniboxPageHandler::ResetController() {	212 void OmniboxPageHandler::ResetController() {

213 controller_.reset(new AutocompleteController(	213 controller_.reset(new AutocompleteController(

214 base::WrapUnique(new ChromeAutocompleteProviderClient(profile_)), this,	214 base::MakeUnique<ChromeAutocompleteProviderClient>(profile_), this,

215 AutocompleteClassifier::kDefaultOmniboxProviders));	215 AutocompleteClassifier::kDefaultOmniboxProviders));

216 }	216 }

OLD	NEW