Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2251263002:
Enable core profile GL on Mac OSX (Closed)
|
Created:
4 years, 4 months ago by Zhenyao Mo Modified:
4 years, 3 months ago CC:
chromium-reviews, piman, ccameron, vmiura Base URL:
https://chromium.googlesource.com/chromium/src.git@more Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionEnable core profile GL on Mac OSX
BUG=635081
TEST=mac bots
NOTRY=true
R=kbr@chromium.org,erikchen@chromium.org
Committed: https://crrev.com/1eb4627c819627991316dc07225cb76d7f3b7e35
Cr-Commit-Position: refs/heads/master@{#415350}
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : rebase #
Depends on Patchset: Messages
Total messages: 33 (21 generated)
The CQ bit was checked by zmo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
LGTM once the tests are passing. Per offline discussion, it may be less risky to land this CL after the M54 branch point, to allow more bake time in Canary and Dev Channel.
The CQ bit was checked by zmo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by zmo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Bots are all green. I'll wait until M54 is branched to land this.
lgtm
The CQ bit was checked by zmo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org Link to the patchset: https://codereview.chromium.org/2251263002/#ps40001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
On 2016/08/26 19:29:40, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...) The mac failures is already there without this CL. See http://crbug.com/508325 Landing with NOTRY
Description was changed from ========== Enable core profile GL on Mac OSX BUG=635081 TEST=mac bots R=kbr@chromium.org,erikchen@chromium.org ========== to ========== Enable core profile GL on Mac OSX BUG=635081 TEST=mac bots NOTRY=true R=kbr@chromium.org,erikchen@chromium.org ==========
The CQ bit was checked by zmo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/08/29 18:15:42, Zhenyao Mo wrote: > On 2016/08/26 19:29:40, commit-bot: I haz the power wrote: > > Try jobs failed on following builders: > > mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, > > > http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...) > > The mac failures is already there without this CL. See http://crbug.com/508325 > > Landing with NOTRY I think it would be safer to disable the test on Mac then and send this through the CQ normally.
The CQ bit was unchecked by zmo@chromium.org
The CQ bit was checked by zmo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Enable core profile GL on Mac OSX BUG=635081 TEST=mac bots NOTRY=true R=kbr@chromium.org,erikchen@chromium.org ========== to ========== Enable core profile GL on Mac OSX BUG=635081 TEST=mac bots NOTRY=true R=kbr@chromium.org,erikchen@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Enable core profile GL on Mac OSX BUG=635081 TEST=mac bots NOTRY=true R=kbr@chromium.org,erikchen@chromium.org ========== to ========== Enable core profile GL on Mac OSX BUG=635081 TEST=mac bots NOTRY=true R=kbr@chromium.org,erikchen@chromium.org Committed: https://crrev.com/1eb4627c819627991316dc07225cb76d7f3b7e35 Cr-Commit-Position: refs/heads/master@{#415350} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/1eb4627c819627991316dc07225cb76d7f3b7e35 Cr-Commit-Position: refs/heads/master@{#415350} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
