Add 360 search engine to Chromium

Add 360 search engine to Chromium

Version number of prepopulated_engines.json is now incremented to 93.

BUG=632842
Committed: https://crrev.com/9b210ce9e224012bcefb72bdf9bcbfa43de83dd3
Cr-Commit-Position: refs/heads/master@{#412904}

[Ian Wen, 2016-08-17 23:44:06]

ianwen@chromium.org changed reviewers:
+ pkasting@chromium.org

[Ian Wen, 2016-08-17 23:44:07]

PTAL :)

[Peter Kasting, 2016-08-18 00:39:55]

LGTM

https://codereview.chromium.org/2251243002/diff/20001/components/search_engin...
File components/search_engines/prepopulated_engines.json (right):

https://codereview.chromium.org/2251243002/diff/20001/components/search_engin...
components/search_engines/prepopulated_engines.json:192: "so_360": {
Nit: I'd just name this "360" and put it atop the list, unless there are
restrictions against doing that.

https://codereview.chromium.org/2251243002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2251243002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:87174: +  <int value="88"
label="360So"/>
Seems like this should be "360" to keep it consistent with the Chrome data
(unless you want it named "360So" everywhere)

[Ian Wen, 2016-08-18 03:13:35]

ianwen@chromium.org changed reviewers:
+ isherman@chromium.org

[Ian Wen, 2016-08-18 03:13:36]

pkasting@: Thank you for such quick response!

isherman@, would you mind taking a look at the histogram changes for the search
engine? Thanks!

https://codereview.chromium.org/2251243002/diff/20001/components/search_engin...
File components/search_engines/prepopulated_engines.json (right):

https://codereview.chromium.org/2251243002/diff/20001/components/search_engin...
components/search_engines/prepopulated_engines.json:192: "so_360": {
On 2016/08/18 00:39:55, Peter Kasting wrote:
> Nit: I'd just name this "360" and put it atop the list, unless there are
> restrictions against doing that.

The reason why I put so_360 instead of 360_so or simply 360 is that the name of
the json entry will be converted to a C++ variable. And unfortunately C++
doesn't allow variable names to start with number.

[Ilya Sherman, 2016-08-18 06:41:12]

histograms.xml lgtm

[Ian Wen, 2016-08-18 17:47:56]

The CQ bit was checked by ianwen@chromium.org

[Ian Wen, 2016-08-18 17:47:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2251243002/#ps40001
(title: "remove "so" from histogram")

[commit-bot: I haz the power, 2016-08-18 17:48:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 19:00:54]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-18 19:02:18]

Description was changed from

==========
Add 360 search engine to Chromium

Version number of prepopulated_engines.json is now incremented to 93.

BUG=632842
==========

to

==========
Add 360 search engine to Chromium

Version number of prepopulated_engines.json is now incremented to 93.

BUG=632842

Committed: https://crrev.com/9b210ce9e224012bcefb72bdf9bcbfa43de83dd3
Cr-Commit-Position: refs/heads/master@{#412904}
==========

[commit-bot: I haz the power, 2016-08-18 19:02:19]

Patchset 3 (id:??) landed as
https://crrev.com/9b210ce9e224012bcefb72bdf9bcbfa43de83dd3
Cr-Commit-Position: refs/heads/master@{#412904}