Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2251213007:
Extend CFI blacklist to include methods with lots of CFI checks. (Closed)
DescriptionExtend CFI blacklist to include methods with lots of CFI checks.
The longer term solution is to implement optimizations in Clang
to avoid generating unnecessary checks.
BUG=634139
Committed: https://crrev.com/8cf09e2797b11ca54ea9162a29353bfba07742a2
Cr-Commit-Position: refs/heads/master@{#413208}
Patch Set 1 #
Messages
Total messages: 21 (10 generated)
krasin@google.com changed reviewers: + kcc@chromium.org
Hi Kostya, please, review this CL. I want us to go forward and enable CFI today to have a chance to collect perf stats on the weekend. Attributes will take time to get approved. For instance, V8 attributes are submitted, but will not reach Chrome src/ until at least tomorrow, and src/cc CL is not getting any attention at all.
See also https://codereview.chromium.org/2259293002/# for which I have not yet got an approval, but hope to get one today.
The CQ bit was checked by kcc@chromium.org
lgtm
The CQ bit was checked by krasin@google.com to run a CQ dry run
The CQ bit was unchecked by krasin@google.com
The CQ bit was checked by krasin@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by krasin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
self LGTM
The CQ bit was checked by krasin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Extend CFI blacklist to include methods with lots of CFI checks. The longer term solution is to implement optimizations in Clang to avoid generating unnecessary checks. BUG=634139 ========== to ========== Extend CFI blacklist to include methods with lots of CFI checks. The longer term solution is to implement optimizations in Clang to avoid generating unnecessary checks. BUG=634139 Committed: https://crrev.com/8cf09e2797b11ca54ea9162a29353bfba07742a2 Cr-Commit-Position: refs/heads/master@{#413208} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/8cf09e2797b11ca54ea9162a29353bfba07742a2 Cr-Commit-Position: refs/heads/master@{#413208} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
