Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2251123002: macviews: honor system control tint setting (Closed)

Created:
4 years, 4 months ago by Elly Fong-Jones
Modified:
4 years, 4 months ago
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

macviews: honor system control tint setting This change: 1. Registers for the NSControlTintDidChange notification 2. Propagates OnNativeThemeChanged to all Views when that notification happens 3. Adds support for color tinting in NativeThemeMac 4. Changes NativeThemeMac to use tinted colors for buttons BUG=603176 Committed: https://crrev.com/c887d72b8386e9a40ad5c983c6b68fa6025471f1 Cr-Commit-Position: refs/heads/master@{#413547}

Patch Set 1 #

Total comments: 2

Patch Set 2 : use luminance #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -1 line) Patch
M ui/native_theme/native_theme_mac.h View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/native_theme/native_theme_mac.mm View 1 6 chunks +28 lines, -1 line 0 comments Download
M ui/views/cocoa/bridged_native_widget.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/cocoa/bridged_native_widget.mm View 3 chunks +11 lines, -0 lines 0 comments Download
M ui/views/cocoa/views_nswindow_delegate.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/cocoa/views_nswindow_delegate.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/controls/button/label_button.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Elly Fong-Jones
sadrul: ptal? :)
4 years, 4 months ago (2016-08-17 16:55:46 UTC) #3
sadrul
The mac code looks reasonable, but I don't know mac well. Adding avi@ as mac ...
4 years, 4 months ago (2016-08-18 03:43:45 UTC) #5
Avi (use Gerrit)
Mostly OK with this, but wonder why you went with the straight average. https://codereview.chromium.org/2251123002/diff/1/ui/native_theme/native_theme_mac.mm File ...
4 years, 4 months ago (2016-08-19 00:21:48 UTC) #6
Elly Fong-Jones
avi: ptal? :) https://codereview.chromium.org/2251123002/diff/1/ui/native_theme/native_theme_mac.mm File ui/native_theme/native_theme_mac.mm (right): https://codereview.chromium.org/2251123002/diff/1/ui/native_theme/native_theme_mac.mm#newcode99 ui/native_theme/native_theme_mac.mm:99: SkColorGetB(color)) / 3; On 2016/08/19 00:21:48, ...
4 years, 4 months ago (2016-08-22 18:17:58 UTC) #7
Avi (use Gerrit)
lgtm Nice!
4 years, 4 months ago (2016-08-22 20:15:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2251123002/20001
4 years, 4 months ago (2016-08-22 20:33:43 UTC) #10
sadrul
lgtm
4 years, 4 months ago (2016-08-22 20:59:43 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-22 21:57:51 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 22:00:22 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c887d72b8386e9a40ad5c983c6b68fa6025471f1
Cr-Commit-Position: refs/heads/master@{#413547}

Powered by Google App Engine
This is Rietveld 408576698