macviews: honor system control tint setting

macviews: honor system control tint setting

This change:
1. Registers for the NSControlTintDidChange notification
2. Propagates OnNativeThemeChanged to all Views when that notification happens
3. Adds support for color tinting in NativeThemeMac
4. Changes NativeThemeMac to use tinted colors for buttons

BUG=603176
Committed: https://crrev.com/c887d72b8386e9a40ad5c983c6b68fa6025471f1
Cr-Commit-Position: refs/heads/master@{#413547}

[Elly Fong-Jones, 2016-08-17 16:55:39]

Description was changed from

==========
macviews: honor system control tint setting

This change:
1. Registers for the NSControlTintDidChange notification
2. Propagates OnNativeThemeChanged to all Views when that notification happens
3. Adds support for color tinting in NativeThemeMac
4. Changes NativeThemeMac to use tinted colors for buttons

BUG=603176
==========

to

==========
macviews: honor system control tint setting

This change:
1. Registers for the NSControlTintDidChange notification
2. Propagates OnNativeThemeChanged to all Views when that notification happens
3. Adds support for color tinting in NativeThemeMac
4. Changes NativeThemeMac to use tinted colors for buttons

BUG=603176
==========

[Elly Fong-Jones, 2016-08-17 16:55:39]

ellyjones@chromium.org changed reviewers:
+ sadrul@chromium.org

[Elly Fong-Jones, 2016-08-17 16:55:46]

sadrul: ptal? :)

[sadrul, 2016-08-18 03:43:44]

sadrul@chromium.org changed reviewers:
+ avi@chromium.org

[sadrul, 2016-08-18 03:43:45]

The mac code looks reasonable, but I don't know mac well. Adding avi@ as mac
owner for ui/

[Avi (use Gerrit), 2016-08-19 00:21:48]

Mostly OK with this, but wonder why you went with the straight average.

https://codereview.chromium.org/2251123002/diff/1/ui/native_theme/native_them...
File ui/native_theme/native_theme_mac.mm (right):

https://codereview.chromium.org/2251123002/diff/1/ui/native_theme/native_them...
ui/native_theme/native_theme_mac.mm:99: SkColorGetB(color)) / 3;
Do we want to do a luminosity average here?
http://www.johndcook.com/blog/2009/08/24/algorithms-convert-color-grayscale/

[Elly Fong-Jones, 2016-08-22 18:17:58]

avi: ptal? :)

https://codereview.chromium.org/2251123002/diff/1/ui/native_theme/native_them...
File ui/native_theme/native_theme_mac.mm (right):

https://codereview.chromium.org/2251123002/diff/1/ui/native_theme/native_them...
ui/native_theme/native_theme_mac.mm:99: SkColorGetB(color)) / 3;
On 2016/08/19 00:21:48, Avi wrote:
> Do we want to do a luminosity average here?
> http://www.johndcook.com/blog/2009/08/24/algorithms-convert-color-grayscale/

Hm! Originally when I tried out luminance it looked ghastly, but I figured out
that there was actually a bug in my first try, and when implemented correctly,
it actually looks better than flat average does. I changed this to use luminance
and attached some comparison screenshots to the bug.

[Avi (use Gerrit), 2016-08-22 20:15:49]

lgtm

Nice!

[Elly Fong-Jones, 2016-08-22 20:32:05]

The CQ bit was checked by ellyjones@chromium.org

[commit-bot: I haz the power, 2016-08-22 20:33:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-08-22 20:59:43]

lgtm

[commit-bot: I haz the power, 2016-08-22 21:57:50]

Description was changed from

==========
macviews: honor system control tint setting

This change:
1. Registers for the NSControlTintDidChange notification
2. Propagates OnNativeThemeChanged to all Views when that notification happens
3. Adds support for color tinting in NativeThemeMac
4. Changes NativeThemeMac to use tinted colors for buttons

BUG=603176
==========

to

==========
macviews: honor system control tint setting

This change:
1. Registers for the NSControlTintDidChange notification
2. Propagates OnNativeThemeChanged to all Views when that notification happens
3. Adds support for color tinting in NativeThemeMac
4. Changes NativeThemeMac to use tinted colors for buttons

BUG=603176
==========

[commit-bot: I haz the power, 2016-08-22 21:57:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-22 22:00:20]

Description was changed from

==========
macviews: honor system control tint setting

This change:
1. Registers for the NSControlTintDidChange notification
2. Propagates OnNativeThemeChanged to all Views when that notification happens
3. Adds support for color tinting in NativeThemeMac
4. Changes NativeThemeMac to use tinted colors for buttons

BUG=603176
==========

to

==========
macviews: honor system control tint setting

This change:
1. Registers for the NSControlTintDidChange notification
2. Propagates OnNativeThemeChanged to all Views when that notification happens
3. Adds support for color tinting in NativeThemeMac
4. Changes NativeThemeMac to use tinted colors for buttons

BUG=603176

Committed: https://crrev.com/c887d72b8386e9a40ad5c983c6b68fa6025471f1
Cr-Commit-Position: refs/heads/master@{#413547}
==========

[commit-bot: I haz the power, 2016-08-22 22:00:22]

Patchset 2 (id:??) landed as
https://crrev.com/c887d72b8386e9a40ad5c983c6b68fa6025471f1
Cr-Commit-Position: refs/heads/master@{#413547}