Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1037)

Unified Diff: media/blink/webmediaplayer_impl_unittest.cc

Issue 2251073003: Pretend the video has no audio track if it is playing as part of autoplay muted. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix tests Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/blink/webmediaplayer_impl_unittest.cc
diff --git a/media/blink/webmediaplayer_impl_unittest.cc b/media/blink/webmediaplayer_impl_unittest.cc
index f903c2d07810ca84704a10c299831241e273c81e..ab422cfb63fe7a066ec8cd8538a6fc4f72e4f816 100644
--- a/media/blink/webmediaplayer_impl_unittest.cc
+++ b/media/blink/webmediaplayer_impl_unittest.cc
@@ -84,9 +84,14 @@ class DummyWebMediaPlayerClient : public blink::WebMediaPlayerClient {
void connectedToRemoteDevice() override {}
void disconnectedFromRemoteDevice() override {}
void cancelledRemotePlaybackRequest() override {}
+ bool isAutoplayingMuted() override { return is_autoplaying_muted_; }
void requestReload(const blink::WebURL& newUrl) override {}
+ void set_is_autoplaying_muted(bool value) { is_autoplaying_muted_ = value; }
+
private:
+ bool is_autoplaying_muted_ = false;
+
DISALLOW_COPY_AND_ASSIGN(DummyWebMediaPlayerClient);
};
@@ -215,6 +220,10 @@ class WebMediaPlayerImplTest : public testing::Test {
return wmpi_->UpdatePlayState_ComputePlayState(false, false, false);
}
+ void SetDelegateState(WebMediaPlayerImpl::DelegateState state) {
+ wmpi_->SetDelegateState(state);
+ }
+
bool IsSuspended() { return wmpi_->pipeline_controller_.IsSuspended(); }
void AddBufferedRanges() {
@@ -653,4 +662,34 @@ TEST_F(WebMediaPlayerImplTest, ComputePlayState_BackgroundedVideoPaused) {
EXPECT_TRUE(state.is_suspended);
}
+TEST_F(WebMediaPlayerImplTest, AutoplayMuted_StartsAndStops) {
+ InitializeDefaultWebMediaPlayerImpl();
+ SetMetadata(true, true);
+ SetReadyState(blink::WebMediaPlayer::ReadyStateHaveFutureData);
+ SetPaused(false);
+
+ EXPECT_CALL(delegate_, DidPlay(_, true, false, false, _));
+ client_.set_is_autoplaying_muted(true);
+ SetDelegateState(WebMediaPlayerImpl::DelegateState::PLAYING);
+
+ EXPECT_CALL(delegate_, DidPlay(_, true, true, false, _));
+ client_.set_is_autoplaying_muted(false);
+ SetDelegateState(WebMediaPlayerImpl::DelegateState::PLAYING);
+}
+
+TEST_F(WebMediaPlayerImplTest, AutoplayMuted_SetVolume) {
+ InitializeDefaultWebMediaPlayerImpl();
+ SetMetadata(true, true);
+ SetReadyState(blink::WebMediaPlayer::ReadyStateHaveFutureData);
+ SetPaused(false);
+
+ EXPECT_CALL(delegate_, DidPlay(_, true, false, false, _));
+ client_.set_is_autoplaying_muted(true);
+ SetDelegateState(WebMediaPlayerImpl::DelegateState::PLAYING);
+
+ EXPECT_CALL(delegate_, DidPlay(_, true, true, false, _));
+ client_.set_is_autoplaying_muted(false);
+ wmpi_->setVolume(1.0);
+}
+
} // namespace media

Powered by Google App Engine
This is Rietveld 408576698