Pretend the video has no audio track if it is playing as part of autoplay muted.

media/blink/webmediaplayer_impl_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/blink/webmediaplayer_impl.h"
 
 #include <stdint.h>
 
 #include <memory>
 
@@ skipping 66 matching lines @@
   }
   void removeVideoTrack(blink::WebMediaPlayer::TrackId) override {}
   void addTextTrack(blink::WebInbandTextTrack*) override {}
   void removeTextTrack(blink::WebInbandTextTrack*) override {}
   void mediaSourceOpened(blink::WebMediaSource*) override {}
   void requestSeek(double) override {}
   void remoteRouteAvailabilityChanged(bool) override {}
   void connectedToRemoteDevice() override {}
   void disconnectedFromRemoteDevice() override {}
   void cancelledRemotePlaybackRequest() override {}
+  bool isAutoplayingMuted() override { return is_autoplaying_muted_; }
   void requestReload(const blink::WebURL& newUrl) override {}
 
+  void set_is_autoplaying_muted(bool value) { is_autoplaying_muted_ = value; }
+
  private:
+  bool is_autoplaying_muted_ = false;
+
   DISALLOW_COPY_AND_ASSIGN(DummyWebMediaPlayerClient);
 };
 
 class MockWebMediaPlayerDelegate
     : public WebMediaPlayerDelegate,
       public base::SupportsWeakPtr<MockWebMediaPlayerDelegate> {
  public:
   MockWebMediaPlayerDelegate() = default;
   ~MockWebMediaPlayerDelegate() = default;
 
@@ skipping 108 matching lines @@
     wmpi_->must_suspend_ = false;
     return wmpi_->UpdatePlayState_ComputePlayState(false, true, false);
   }
 
   WebMediaPlayerImpl::PlayState ComputeMustSuspendPlayState() {
     wmpi_->is_idle_ = false;
     wmpi_->must_suspend_ = true;
     return wmpi_->UpdatePlayState_ComputePlayState(false, false, false);
   }
 
+  void SetDelegateState(WebMediaPlayerImpl::DelegateState state) {
+    wmpi_->SetDelegateState(state);
+  }
+
   bool IsSuspended() { return wmpi_->pipeline_controller_.IsSuspended(); }
 
   void AddBufferedRanges() {
     wmpi_->buffered_data_source_host_.AddBufferedByteRange(0, 1);
   }
 
   void SetupForResumingBackgroundVideo() {
 #if !defined(OS_ANDROID)
     // Need to enable media suspend to test resuming background videos.
     base::CommandLine::ForCurrentProcess()->AppendSwitch(
@@ skipping 418 matching lines @@
 
   EXPECT_CALL(delegate_, IsPlayingBackgroundVideo()).WillOnce(Return(false));
   EXPECT_CALL(delegate_, IsHidden()).WillRepeatedly(Return(true));
 
   state = ComputeBackgroundedPlayState();
   EXPECT_EQ(WebMediaPlayerImpl::DelegateState::PAUSED, state.delegate_state);
   EXPECT_FALSE(state.is_memory_reporting_enabled);
   EXPECT_TRUE(state.is_suspended);
 }
 
+TEST_F(WebMediaPlayerImplTest, SetVolumeCallsDidPlay) {

[sandersd (OOO until July 31), 2016/10/04 23:53:04]

We don't have tests that all the other triggers result in play state
computation.

I assume you are more worried about this one since the link is indirect. In that
case, a comment above the UpdatePlayState() call would be more effective. (And
will help more with the inevitable refactors of the code.)

[mlamouri (slow - plz ping), 2016/10/05 16:19:49]

Added the comment and removed the test.

+  InitializeDefaultWebMediaPlayerImpl();
+  SetMetadata(true, true);
+  SetReadyState(blink::WebMediaPlayer::ReadyStateHaveFutureData);
+  SetPaused(false);
+
+  EXPECT_CALL(delegate_, DidPlay(_, _, _, _, _));
+  wmpi_->setVolume(1.0);
+}
+
+TEST_F(WebMediaPlayerImplTest, AutoplayMuted_StartsAndStops) {
+  InitializeDefaultWebMediaPlayerImpl();
+  WebMediaPlayerImpl::PlayState state;
+  SetMetadata(true, true);
+  SetReadyState(blink::WebMediaPlayer::ReadyStateHaveFutureData);
+  SetPaused(false);
+
+  EXPECT_CALL(delegate_, DidPlay(_, true, false, false, _));
+  EXPECT_CALL(delegate_, DidPlay(_, true, true, false, _));

[sandersd (OOO until July 31), 2016/10/04 23:53:04]

Move these right before the respective SetDelegateState() calls?

[mlamouri (slow - plz ping), 2016/10/05 16:19:49]

Done.

+
+  client_.set_is_autoplaying_muted(true);
+  state = ComputePlayState();
+  EXPECT_EQ(WebMediaPlayerImpl::DelegateState::PLAYING, state.delegate_state);
+  SetDelegateState(state.delegate_state);

[sandersd (OOO until July 31), 2016/10/04 23:53:04]

This seems to be testing two different things. Probably you should be calling
ComputePlayState() and only worrying about the DidPlay() result?

[mlamouri (slow - plz ping), 2016/10/05 16:19:49]

I'm not sure I'm following this. ComputePlayState() doesn't call DidPlay() but
SetDelegateState() does. I can as well pass "PLAYING" to SetDelegateState to
reduce the overhead.

[sandersd (OOO until July 31), 2016/10/05 17:38:17]

Sorry, I should have said UpdatePlayState().

+
+  client_.set_is_autoplaying_muted(false);
+  state = ComputePlayState();
+  EXPECT_EQ(WebMediaPlayerImpl::DelegateState::PLAYING, state.delegate_state);
+  SetDelegateState(state.delegate_state);
+}
+
+TEST_F(WebMediaPlayerImplTest, AutoplayMuted_SetVolume) {
+  InitializeDefaultWebMediaPlayerImpl();
+  WebMediaPlayerImpl::PlayState state;
+  SetMetadata(true, true);
+  SetReadyState(blink::WebMediaPlayer::ReadyStateHaveFutureData);
+  SetPaused(false);
+
+  EXPECT_CALL(delegate_, DidPlay(_, true, false, false, _));
+  EXPECT_CALL(delegate_, DidPlay(_, true, true, false, _));
+
+  client_.set_is_autoplaying_muted(true);
+  state = ComputePlayState();
+  EXPECT_EQ(WebMediaPlayerImpl::DelegateState::PLAYING, state.delegate_state);
+  SetDelegateState(state.delegate_state);
+
+  client_.set_is_autoplaying_muted(false);
+  wmpi_->setVolume(1.0);
+}
+
 }  // namespace media