Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 2251053003: Revert of Reset the focus after windows are restored, and grids are shutdown. (Closed)

Created:
4 years, 4 months ago by oshima
Modified:
4 years, 4 months ago
Reviewers:
varkha
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reset the focus after windows are restored, and grids are shutdown. (patchset #4 id:60001 of https://codereview.chromium.org/2244173006/ ) Reason for revert: Reverting because this can cause crash with arc++ windows. Original issue's description: > ResetFocusRestoreWindow may change activation, which can resize the window, which then results in reposition. This prevents it by updating the focus after grids are shutdown. > > BUG=634572 > > Committed: https://crrev.com/e26c7e4886eec4d2c58a5810b6440f7faa4293ea > Cr-Commit-Position: refs/heads/master@{#412384} TBR=varkha@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=634572 Committed: https://crrev.com/0563bb605d6d4596510d7d65d0b1041632287402 Cr-Commit-Position: refs/heads/master@{#412602}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M ash/common/wm/overview/window_selector.cc View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
oshima
Created Revert of Reset the focus after windows are restored, and grids are shutdown.
4 years, 4 months ago (2016-08-17 18:57:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2251053003/1
4 years, 4 months ago (2016-08-17 18:58:18 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-17 18:59:02 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 19:01:09 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0563bb605d6d4596510d7d65d0b1041632287402
Cr-Commit-Position: refs/heads/master@{#412602}

Powered by Google App Engine
This is Rietveld 408576698