Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2251023003: Remove single active state restriction. (Closed)

Created:
4 years, 4 months ago by michaeldo
Modified:
4 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove single active state restriction. Remove the restriction that only a single state can be active at a time. This is to allow incognito and normal mode WKWebViews live side by side where they can be two active states at any given time. BUG=579264 Committed: https://crrev.com/93070bc438d3de8324b370cbe3e0fbb36c5ab6cb Cr-Commit-Position: refs/heads/master@{#430298}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M ios/web/active_state_manager_impl.mm View 2 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
michaeldo
4 years, 4 months ago (2016-08-17 17:59:42 UTC) #2
Eugene But (OOO till 7-30)
Please explain in CL description why this change is necessary and safe. Adding Benoit, as ...
4 years, 4 months ago (2016-08-17 18:04:26 UTC) #4
bzanotti
On 2016/08/17 18:04:26, Eugene But wrote: > Please explain in CL description why this change ...
4 years, 4 months ago (2016-08-18 09:11:51 UTC) #7
Eugene But (OOO till 7-30)
Thanks Benoit. This matches my vague recollection. LGTM!
4 years, 4 months ago (2016-08-18 14:15:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2251023003/1
4 years, 1 month ago (2016-11-07 16:48:00 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-07 16:58:28 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 17:13:37 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/93070bc438d3de8324b370cbe3e0fbb36c5ab6cb
Cr-Commit-Position: refs/heads/master@{#430298}

Powered by Google App Engine
This is Rietveld 408576698