Remove single active state restriction.

Remove single active state restriction.

Remove the restriction that only a single state can be active at a time.
This is to allow incognito and normal mode WKWebViews live side by
side where they can be two active states at any given time.

BUG=579264
Committed: https://crrev.com/93070bc438d3de8324b370cbe3e0fbb36c5ab6cb
Cr-Commit-Position: refs/heads/master@{#430298}

[michaeldo, 2016-08-17 17:59:41]

michaeldo@chromium.org changed reviewers:
+ eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2016-08-17 18:04:25]

eugenebut@chromium.org changed reviewers:
+ bzanotti@chromium.org

[Eugene But (OOO till 7-30), 2016-08-17 18:04:26]

Please explain in CL description why this change is necessary and safe. Adding
Benoit, as he hopefully understands why these DCHECKs exist.

[michaeldo, 2016-08-17 18:46:49]

Description was changed from

==========
Remove single active state restriction.

Remove the restriction that only a single state can be active at a time.

BUG=579264
==========

to

==========
Remove single active state restriction.

Remove the restriction that only a single state can be active at a time. This is
to allow incognito and normal mode WKWebViews live side by side where they can
be two active states at any given time.

BUG=579264
==========

[michaeldo, 2016-08-17 18:47:11]

Description was changed from

==========
Remove single active state restriction.

Remove the restriction that only a single state can be active at a time. This is
to allow incognito and normal mode WKWebViews live side by side where they can
be two active states at any given time.

BUG=579264
==========

to

==========
Remove single active state restriction.

Remove the restriction that only a single state can be active at a time.
This is to allow incognito and normal mode WKWebViews live side by
side where they can be two active states at any given time.

BUG=579264
==========

[bzanotti, 2016-08-18 09:11:51]

On 2016/08/17 18:04:26, Eugene But wrote:
> Please explain in CL description why this change is necessary and safe. Adding
> Benoit, as he hopefully understands why these DCHECKs exist.

I took a look at this CL, the history of the file and the initial bugs
(http://crbug.com/480654 and http://crbug.com/480507).

It seems that the restriction has been added for a project that wasn't used
eventually (but I'm not sure, we should double-check that there is no chance of
data being shared by having two WKWebViews from two different BrowserState
side-to-side). ActiveStateManager was repurposed instead of being removed as it
was useful for AccountConsistencyService and GaiaAuthFetcherIOS. Nowadays,
AFAICT, ActiveStateManager is only used to ensure no WKWebView (and the
associated WKConfiguration) is alive when data is being removed. Since different
BrowserState have (I think?) different WKConfiguration, the restriction doesn't
seem to be useful anymore and can be removed.

[Eugene But (OOO till 7-30), 2016-08-18 14:15:11]

Thanks Benoit. This matches my vague recollection. LGTM!

[michaeldo, 2016-11-07 16:47:30]

The CQ bit was checked by michaeldo@chromium.org

[commit-bot: I haz the power, 2016-11-07 16:48:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 16:58:27]

Description was changed from

==========
Remove single active state restriction.

Remove the restriction that only a single state can be active at a time.
This is to allow incognito and normal mode WKWebViews live side by
side where they can be two active states at any given time.

BUG=579264
==========

to

==========
Remove single active state restriction.

Remove the restriction that only a single state can be active at a time.
This is to allow incognito and normal mode WKWebViews live side by
side where they can be two active states at any given time.

BUG=579264
==========

[commit-bot: I haz the power, 2016-11-07 16:58:28]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-07 17:13:37]

Description was changed from

==========
Remove single active state restriction.

Remove the restriction that only a single state can be active at a time.
This is to allow incognito and normal mode WKWebViews live side by
side where they can be two active states at any given time.

BUG=579264
==========

to

==========
Remove single active state restriction.

Remove the restriction that only a single state can be active at a time.
This is to allow incognito and normal mode WKWebViews live side by
side where they can be two active states at any given time.

BUG=579264

Committed: https://crrev.com/93070bc438d3de8324b370cbe3e0fbb36c5ab6cb
Cr-Commit-Position: refs/heads/master@{#430298}
==========

[commit-bot: I haz the power, 2016-11-07 17:13:37]

Patchset 1 (id:??) landed as
https://crrev.com/93070bc438d3de8324b370cbe3e0fbb36c5ab6cb
Cr-Commit-Position: refs/heads/master@{#430298}