Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2251013002: Fixing crash in AutoplayUmaHelper when registering unload event listener (Closed)

Created:
4 years, 4 months ago by Zhiqiang Zhang (Slow)
Modified:
4 years, 4 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing crash in AutoplayUmaHelper when registering unload event listener BUG=638532 Committed: https://crrev.com/62aaed7a152349ff11850f9e8fbb6d2b91311764 Cr-Commit-Position: refs/heads/master@{#412506}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M third_party/WebKit/Source/core/html/AutoplayUmaHelper.cpp View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Zhiqiang Zhang (Slow)
4 years, 4 months ago (2016-08-17 10:17:11 UTC) #3
mlamouri (slow - plz ping)
lgtm
4 years, 4 months ago (2016-08-17 10:23:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2251013002/1
4 years, 4 months ago (2016-08-17 12:10:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-17 12:13:52 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 12:15:51 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62aaed7a152349ff11850f9e8fbb6d2b91311764
Cr-Commit-Position: refs/heads/master@{#412506}

Powered by Google App Engine
This is Rietveld 408576698