Issue 2251003003: Merged 7fe4d930c9772dfc5f8e506920ad435863ee3b1d

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2251003003: Merged 7fe4d930c9772dfc5f8e506920ad435863ee3b1d (Closed)

Created:
4 years, 4 months ago by neis

Modified:
4 years, 4 months ago

Reviewers:
Michael Hablich

CC:
v8-reviews_googlegroups.com, oth, v8-merges_googlegroups.com, rmcilroy

Base URL:
https://chromium.googlesource.com/v8/v8.git@5.3

Target Ref:
refs/pending/branch-heads/5.3

Project:
v8

Visibility:
Public.

More Reviews

Description

Merged 7fe4d930c9772dfc5f8e506920ad435863ee3b1d [interpreter] Don't assume generator functions do an initial yield. R=hablich@chromium.org NOTRY=true NOPRESUBMIT=true BUG=chromium:638019

Patch Set 1 #

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -13 lines)			Patch
M	src/interpreter/bytecode-generator.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	test/cctest/interpreter/bytecode_expectations/Generators.golden	View	9 chunks	+18 lines, -12 lines	0 comments	Download
M	test/mjsunit/harmony/async-await-basic.js	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2251003003/1

4 years, 4 months ago (2016-08-18 08:39:41 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages