Chromium Code Reviews| Index: chrome/browser/permissions/permission_uma_util.h |
| diff --git a/chrome/browser/permissions/permission_uma_util.h b/chrome/browser/permissions/permission_uma_util.h |
| index e920c3e3a918576f7a20dc5bb27a5831a7b62242..152b5e6e3a21ab1ea2df53473ca01bf1042fa420 100644 |
| --- a/chrome/browser/permissions/permission_uma_util.h |
| +++ b/chrome/browser/permissions/permission_uma_util.h |
| @@ -40,11 +40,19 @@ class PermissionUmaUtil { |
| static const char kPermissionsPromptShownGesture[]; |
| static const char kPermissionsPromptShownNoGesture[]; |
| static const char kPermissionsPromptAccepted[]; |
| + static const char kPermissionsPromptAcceptedPriorDismissCountPrefix[]; |
| + static const char kPermissionsPromptAcceptedPriorIgnoreCountPrefix[]; |
| static const char kPermissionsPromptAcceptedGesture[]; |
| static const char kPermissionsPromptAcceptedNoGesture[]; |
| static const char kPermissionsPromptDenied[]; |
| + static const char kPermissionsPromptDeniedPriorDismissCountPrefix[]; |
| + static const char kPermissionsPromptDeniedPriorIgnoreCountPrefix[]; |
| static const char kPermissionsPromptDeniedGesture[]; |
| static const char kPermissionsPromptDeniedNoGesture[]; |
| + static const char kPermissionsPromptDismissedPriorDismissCountPrefix[]; |
| + static const char kPermissionsPromptDismissedPriorIgnoreCountPrefix[]; |
| + static const char kPermissionsPromptIgnoredPriorDismissCountPrefix[]; |
| + static const char kPermissionsPromptIgnoredPriorIgnoreCountPrefix[]; |
| static const char kPermissionsPromptRequestsPerPrompt[]; |
| static const char kPermissionsPromptMergedBubbleTypes[]; |
| static const char kPermissionsPromptMergedBubbleAccepted[]; |
| @@ -99,16 +107,6 @@ class PermissionUmaUtil { |
| static void PermissionPromptDenied( |
| const std::vector<PermissionRequest*>& requests); |
| - // Records |count| total dismissal actions for a prompt of type |permission| |
| - // for a single origin. |
| - static void PermissionPromptDismissed(content::PermissionType permission, |
| - int count); |
| - |
| - // Records |count| total ignore actions for a prompt of type |permission| for |
| - // a single origin. |
| - static void PermissionPromptIgnored(content::PermissionType permission, |
| - int count); |
| - |
| // A permission prompt was accepted or denied, and the prompt displayed a |
| // persistence toggle. Records whether the toggle was enabled (persist) or |
| // disabled (don't persist). |
| @@ -132,6 +130,13 @@ class PermissionUmaUtil { |
| const GURL& requesting_origin, |
| Profile* profile); |
| + // Records |count| total prior actions for a prompt of type |permission| |
| + // for a single origin using |prefix| for the metric. |
| + static void RecordPermissionPromptPriorCount( |
| + content::PermissionType permission, |
| + const char* prefix, |
|
Ilya Sherman
2016/08/18 00:59:00
nit: Probably best to pass a string or a StringPie
dominickn
2016/08/18 01:21:11
Done.
|
| + int count); |
| + |
| DISALLOW_IMPLICIT_CONSTRUCTORS(PermissionUmaUtil); |
| }; |