Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 2250993002: Add prior dismissal and ignore count metrics for all permission actions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@kendra-permission-action-reporting
Patch Set: Address comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« chrome/browser/permissions/permission_uma_util.cc ('K') | « chrome/browser/permissions/permission_uma_util.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index cc783b848d0b4883dbfe31779a3ded257ce5dda8..a5255ab9616a27433b290fa0efa369da1693f497 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -39983,6 +39983,26 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="Permissions.Prompt.Accepted.PriorDismissCount">
+ <owner>dominickn@chromium.org</owner>
+ <summary>
+ This metric, recorded at the time of a permission prompt accept, records the
+ total number of prompt dismissal events for this origin since the last time
+ the user cleared their history or site data and prior to the accept. The
+ suffix of the histogram indicates which particular permission.
+ </summary>
+</histogram>
+
+<histogram name="Permissions.Prompt.Accepted.PriorIgnoreCount">
+ <owner>dominickn@chromium.org</owner>
+ <summary>
+ This metric, recorded at the time of a permission prompt accept, records the
+ total number of prompt ignore events for this origin since the last time the
+ user cleared their history or site data and prior to the accept. The suffix
+ of the histogram indicates which particular permission.
+ </summary>
+</histogram>
+
<histogram name="Permissions.Prompt.Denied" enum="PermissionRequestType">
<owner>benwells@chromium.org</owner>
<owner>tsergeant@chromium.org</owner>
@@ -40001,8 +40021,31 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="Permissions.Prompt.Denied.PriorDismissCount">
+ <owner>dominickn@chromium.org</owner>
+ <summary>
+ This metric, recorded at the time of a permission prompt deny, records the
+ total number of prompt dismissal events for this origin since the last time
+ the user cleared their history or site data and prior to the accept. The
+ suffix of the histogram indicates which particular permission.
+ </summary>
+</histogram>
+
+<histogram name="Permissions.Prompt.Denied.PriorIgnoreCount">
+ <owner>dominickn@chromium.org</owner>
+ <summary>
+ This metric, recorded at the time of a permission prompt deny, records the
+ total number of prompt ignore events for this origin since the last time the
+ user cleared their history or site data and prior to the accept. The suffix
+ of the histogram indicates which particular permission.
+ </summary>
+</histogram>
+
<histogram name="Permissions.Prompt.DismissCount">
<owner>dominickn@chromium.org</owner>
+ <obsolete>
+ Renamed to Permissions.Prompt.Dismissed.PriorDismissCount on 17 August 2016.
+ </obsolete>
<summary>
This metric, recorded at the time of a permission prompt dismissal, records
the total number of prompt dismissal events for this origin since the last
@@ -40013,8 +40056,31 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
raymes 2016/08/22 02:55:09 Since these have only been on canary for a very sh
Ilya Sherman 2016/08/22 20:42:33 It's generally preferable to mark as <obsolete> so
dominickn 2016/08/22 22:40:51 Acknowledged. Leaving as obsolete.
+<histogram name="Permissions.Prompt.Dismissed.PriorDismissCount">
+ <owner>dominickn@chromium.org</owner>
+ <summary>
+ This metric, recorded at the time of a permission prompt dismiss, records
+ the total number of prompt dismissal events for this origin since the last
+ time the user cleared their history or site data and prior to the dismiss.
+ The suffix of the histogram indicates which particular permission.
+ </summary>
+</histogram>
+
+<histogram name="Permissions.Prompt.Dismissed.PriorIgnoreCount">
+ <owner>dominickn@chromium.org</owner>
+ <summary>
+ This metric, recorded at the time of a permission prompt dismiss, records
+ the total number of prompt ignore events for this origin since the last time
+ the user cleared their history or site data and prior to the dismiss. The
+ suffix of the histogram indicates which particular permission.
+ </summary>
+</histogram>
+
<histogram name="Permissions.Prompt.IgnoreCount">
<owner>dominickn@chromium.org</owner>
+ <obsolete>
+ Renamed to Permissions.Prompt.Dismissed.PriorDismissCount on 17 August 2016.
+ </obsolete>
<summary>
This metric, recorded at the time of a permission prompt ignore, records the
total number of prompt ignore events for this origin since the last time the
@@ -40025,6 +40091,26 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="Permissions.Prompt.Ignored.PriorDismissCount">
+ <owner>dominickn@chromium.org</owner>
+ <summary>
+ This metric, recorded at the time of a permission prompt ignore, records the
+ total number of prompt dismissal events for this origin since the last time
+ the user cleared their history or site data and prior to the ignore. The
+ suffix of the histogram indicates which particular permission.
+ </summary>
+</histogram>
+
+<histogram name="Permissions.Prompt.Ignored.PriorIgnoreCount">
+ <owner>dominickn@chromium.org</owner>
+ <summary>
+ This metric, recorded at the time of a permission prompt ignore, records the
+ total number of prompt ignore events for this origin since the last time the
+ user cleared their history or site data and prior to the ignore. The suffix
+ of the histogram indicates which particular permission.
+ </summary>
+</histogram>
+
<histogram name="Permissions.Prompt.MergedBubbleAccepted"
enum="PermissionRequestType">
<owner>benwells@chromium.org</owner>
@@ -101500,9 +101586,15 @@ To add a new entry, add it with any value and run test to compute valid value.
<affected-histogram name="Permissions.Action.InsecureOrigin"/>
<affected-histogram name="Permissions.Action.SecureOrigin"/>
<affected-histogram name="Permissions.Prompt.Accepted.Persisted"/>
+ <affected-histogram name="Permissions.Prompt.Accepted.PriorDismissCount"/>
+ <affected-histogram name="Permissions.Prompt.Accepted.PriorIgnoreCount"/>
<affected-histogram name="Permissions.Prompt.Denied.Persisted"/>
- <affected-histogram name="Permissions.Prompt.DismissCount"/>
- <affected-histogram name="Permissions.Prompt.IgnoreCount"/>
+ <affected-histogram name="Permissions.Prompt.Denied.PriorDismissCount"/>
+ <affected-histogram name="Permissions.Prompt.Denied.PriorIgnoreCount"/>
+ <affected-histogram name="Permissions.Prompt.Dismissed.PriorDismissCount"/>
+ <affected-histogram name="Permissions.Prompt.Dismissed.PriorIgnoreCount"/>
+ <affected-histogram name="Permissions.Prompt.Ignored.PriorDismissCount"/>
+ <affected-histogram name="Permissions.Prompt.Ignored.PriorIgnoreCount"/>
<affected-histogram name="Permissions.Requested.CrossOrigin"/>
</histogram_suffixes>
« chrome/browser/permissions/permission_uma_util.cc ('K') | « chrome/browser/permissions/permission_uma_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698