Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2250973002: Revert of Inherit appropiate environment variables in goma module for goma_utils.py (Closed)

Created:
4 years, 4 months ago by Paweł Hajdan Jr.
Modified:
4 years, 4 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Inherit appropiate environment variables in goma module for goma_utils.py (patchset #7 id:120001 of https://codereview.chromium.org/2245553002/ ) Reason for revert: This interacts badly with the recipe autoroller, see e.g. https://goto.google.com/tezblb . Original issue's description: > Inherit appropiate environment variables in goma module for goma_utils.py > > goma_utils.py finds a compiler_proxy.INFO from temporary dir set in env. > But, there is not consistency with glog temporary dir. > glog uses GLOG_log_dir if it is set in env. > By inheriting some env variables and forbidding GLOG_log_dir, > goma_util.py can find the INFO file from correct location. > > * inherit some env vars to upload with log in goma_utils.SendGomaTsMon(). > * if GLOG_log_dir is set, assertion failed. > * stop to use GOMA_TMP_DIR as candidate directory for glog *.INFO files. > * rename GetGomaTmpDirectory -> GetGomaLogDirectory in goma_utils.py > > BUG=544330 > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/6da5a843e44836e7b7b084a6eca6c65eb4b4f16b TBR=shinyak@chromium.org,ukai@chromium.org,yyanagisawa@chromium.org,tikuta@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=544330 Committed: https://chromium.googlesource.com/chromium/tools/build/+/651d39886fe48124507af6a74459abf3751d9768

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -52 lines) Patch
M scripts/slave/goma_utils.py View 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipe_modules/goma/api.py View 5 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipe_modules/goma/example.expected/linux.json View 1 chunk +0 lines, -3 lines 0 comments Download
M scripts/slave/recipe_modules/goma/example.expected/linux_upload_logs.json View 1 chunk +0 lines, -5 lines 0 comments Download
M scripts/slave/recipe_modules/goma/example.expected/mac.json View 1 chunk +0 lines, -3 lines 0 comments Download
M scripts/slave/recipe_modules/goma/example.expected/mac_upload_logs.json View 1 chunk +0 lines, -5 lines 0 comments Download
M scripts/slave/recipe_modules/goma/example.expected/win.json View 1 chunk +0 lines, -3 lines 0 comments Download
M scripts/slave/recipe_modules/goma/example.expected/win_upload_logs.json View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paweł Hajdan Jr.
Created Revert of Inherit appropiate environment variables in goma module for goma_utils.py
4 years, 4 months ago (2016-08-17 08:32:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2250973002/1
4 years, 4 months ago (2016-08-17 08:32:46 UTC) #3
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 08:33:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/651d39886fe48124507a...

Powered by Google App Engine
This is Rietveld 408576698