Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2250963004:
Use keepclassmembers for android.webkit.JavascriptInterface in proguard (Closed)
DescriptionUse keepclassmembers for android.webkit.JavascriptInterface in proguard
This CL uses -keepclassmembers for
android.webkit.JavascriptInterface instead of
-keepclasseswithmembers in proguard.
The reason is because keeping methods is enough for files
annotated with for android.webkit.JavascriptInterface.
BUG=634998
Committed: https://crrev.com/761ef674d6498bad0f6c1bbdbbfcec59ffe5bafb
Cr-Commit-Position: refs/heads/master@{#412818}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Address smaier comments #Messages
Total messages: 15 (7 generated)
Patchset #1 (id:1) has been deleted
xunjieli@chromium.org changed reviewers: + smaier@chromium.org, torne@chromium.org
I am not familiar with android.webkit.JavascriptInterface, but it looks like it isn't used in base. It is okay to move it to Webview where it is used? PTAL. Thanks!
https://codereview.chromium.org/2250963004/diff/20001/base/android/base_progu... File base/android/base_proguard_config.flags (left): https://codereview.chromium.org/2250963004/diff/20001/base/android/base_progu... base/android/base_proguard_config.flags:21: -keepclasseswithmembers class * { I'd prefer you just change this to -keepclassmembers. It makes sense that anyone adding a Javascript interface will want that function kept around, and I'm not sure it's safe to assume webview will be the only ones to use it.
Description was changed from ========== Move android.webkit.JavascriptInterface proguard rule to android_webview/apk/java/proguard.flags @android.webkit.JavascriptInterface annotation is not used in base. This CL moves it out of base_proguard_config.flags. BUG=634998 ========== to ========== Use keepclassmembers for android.webkit.JavascriptInterface in proguard This CL uses -keepclassmembers for android.webkit.JavascriptInterface instead of -keepclasseswithmembers in proguard. The reason is because keeping methods is enough for files annotated with for android.webkit.JavascriptInterface. BUG=634998 ==========
Description was changed from ========== Use keepclassmembers for android.webkit.JavascriptInterface in proguard This CL uses -keepclassmembers for android.webkit.JavascriptInterface instead of -keepclasseswithmembers in proguard. The reason is because keeping methods is enough for files annotated with for android.webkit.JavascriptInterface. BUG=634998 ========== to ========== Use keepclassmembers for android.webkit.JavascriptInterface in proguard This CL uses -keepclassmembers for android.webkit.JavascriptInterface instead of -keepclasseswithmembers in proguard. The reason is because keeping methods is enough for files annotated with for android.webkit.JavascriptInterface. BUG=634998 ==========
Thanks for the review. PTAL. https://codereview.chromium.org/2250963004/diff/20001/base/android/base_progu... File base/android/base_proguard_config.flags (left): https://codereview.chromium.org/2250963004/diff/20001/base/android/base_progu... base/android/base_proguard_config.flags:21: -keepclasseswithmembers class * { On 2016/08/17 19:15:41, smaier wrote: > I'd prefer you just change this to -keepclassmembers. It makes sense that anyone > adding a Javascript interface will want that function kept around, and I'm not > sure it's safe to assume webview will be the only ones to use it. Done.
On 2016/08/17 19:23:55, xunjieli wrote: > Thanks for the review. PTAL. > > https://codereview.chromium.org/2250963004/diff/20001/base/android/base_progu... > File base/android/base_proguard_config.flags (left): > > https://codereview.chromium.org/2250963004/diff/20001/base/android/base_progu... > base/android/base_proguard_config.flags:21: -keepclasseswithmembers class * { > On 2016/08/17 19:15:41, smaier wrote: > > I'd prefer you just change this to -keepclassmembers. It makes sense that > anyone > > adding a Javascript interface will want that function kept around, and I'm not > > sure it's safe to assume webview will be the only ones to use it. > > Done. lgtm
LGTM
The CQ bit was checked by xunjieli@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Use keepclassmembers for android.webkit.JavascriptInterface in proguard This CL uses -keepclassmembers for android.webkit.JavascriptInterface instead of -keepclasseswithmembers in proguard. The reason is because keeping methods is enough for files annotated with for android.webkit.JavascriptInterface. BUG=634998 ========== to ========== Use keepclassmembers for android.webkit.JavascriptInterface in proguard This CL uses -keepclassmembers for android.webkit.JavascriptInterface instead of -keepclasseswithmembers in proguard. The reason is because keeping methods is enough for files annotated with for android.webkit.JavascriptInterface. BUG=634998 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Use keepclassmembers for android.webkit.JavascriptInterface in proguard This CL uses -keepclassmembers for android.webkit.JavascriptInterface instead of -keepclasseswithmembers in proguard. The reason is because keeping methods is enough for files annotated with for android.webkit.JavascriptInterface. BUG=634998 ========== to ========== Use keepclassmembers for android.webkit.JavascriptInterface in proguard This CL uses -keepclassmembers for android.webkit.JavascriptInterface instead of -keepclasseswithmembers in proguard. The reason is because keeping methods is enough for files annotated with for android.webkit.JavascriptInterface. BUG=634998 Committed: https://crrev.com/761ef674d6498bad0f6c1bbdbbfcec59ffe5bafb Cr-Commit-Position: refs/heads/master@{#412818} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/761ef674d6498bad0f6c1bbdbbfcec59ffe5bafb Cr-Commit-Position: refs/heads/master@{#412818} |
