Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2250943002: Convert editing/style/relative-font-size-change-00[1-4].html to use w3c test harness (Closed)

Created:
4 years, 4 months ago by yosin_UTC9
Modified:
4 years, 4 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/style/relative-font-size-change-00[1-4].html to use w3c test harness This patch converts "editing/style/relative-font-size-change-00[1-4].html" to use w3c test harness and integrates into "relative_font_size_change.html", since both test cases are very similar, to simplify test script for improving readability. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/25cb7a2c691f668be41ea6ba5dcfe77313a9bd8a Cr-Commit-Position: refs/heads/master@{#412487}

Patch Set 1 : 2016-08-17T15:19:30 #

Total comments: 2

Patch Set 2 : 2016-08-17T18:14:32 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -942 lines) Patch
D third_party/WebKit/LayoutTests/editing/style/relative-font-size-change-001.html View 1 chunk +0 lines, -60 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/style/relative-font-size-change-002.html View 1 chunk +0 lines, -60 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/style/relative-font-size-change-003.html View 1 chunk +0 lines, -65 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/style/relative-font-size-change-004.html View 1 chunk +0 lines, -64 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/style/relative_font_size_change.html View 1 1 chunk +85 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/style/relative-font-size-change-001-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/style/relative-font-size-change-001-expected.txt View 1 chunk +0 lines, -49 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/style/relative-font-size-change-002-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/style/relative-font-size-change-002-expected.txt View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/style/relative-font-size-change-003-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/style/relative-font-size-change-003-expected.txt View 1 chunk +0 lines, -70 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/style/relative-font-size-change-004-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/style/relative-font-size-change-004-expected.txt View 1 chunk +0 lines, -62 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/style/relative-font-size-change-001-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/style/relative-font-size-change-001-expected.txt View 1 chunk +0 lines, -49 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/style/relative-font-size-change-002-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/style/relative-font-size-change-002-expected.txt View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/style/relative-font-size-change-003-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/style/relative-font-size-change-003-expected.txt View 1 chunk +0 lines, -70 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/style/relative-font-size-change-004-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/style/relative-font-size-change-004-expected.txt View 1 chunk +0 lines, -62 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/style/relative-font-size-change-001-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/style/relative-font-size-change-001-expected.txt View 1 chunk +0 lines, -49 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/style/relative-font-size-change-002-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/style/relative-font-size-change-002-expected.txt View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/style/relative-font-size-change-003-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/style/relative-font-size-change-003-expected.txt View 1 chunk +0 lines, -70 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/style/relative-font-size-change-004-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/style/relative-font-size-change-004-expected.txt View 1 chunk +0 lines, -62 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
yosin_UTC9
PTAL
4 years, 4 months ago (2016-08-17 07:02:56 UTC) #5
yosin_UTC9
PTAL
4 years, 4 months ago (2016-08-17 07:03:07 UTC) #6
yosin_UTC9
linux bot failed fast/images/image-change-without-resize-shouldnt-layout.html This failure isn't related to this patch. (`_')
4 years, 4 months ago (2016-08-17 08:57:42 UTC) #9
Xiaocheng
lgtm with a nit https://codereview.chromium.org/2250943002/diff/1/third_party/WebKit/LayoutTests/editing/style/relative_font_size_change.html File third_party/WebKit/LayoutTests/editing/style/relative_font_size_change.html (right): https://codereview.chromium.org/2250943002/diff/1/third_party/WebKit/LayoutTests/editing/style/relative_font_size_change.html#newcode44 third_party/WebKit/LayoutTests/editing/style/relative_font_size_change.html:44: 'selection characters'); Nit: could you ...
4 years, 4 months ago (2016-08-17 09:08:38 UTC) #10
yosin_UTC9
Thanks for reviewing! Committing... https://codereview.chromium.org/2250943002/diff/1/third_party/WebKit/LayoutTests/editing/style/relative_font_size_change.html File third_party/WebKit/LayoutTests/editing/style/relative_font_size_change.html (right): https://codereview.chromium.org/2250943002/diff/1/third_party/WebKit/LayoutTests/editing/style/relative_font_size_change.html#newcode44 third_party/WebKit/LayoutTests/editing/style/relative_font_size_change.html:44: 'selection characters'); On 2016/08/17 at ...
4 years, 4 months ago (2016-08-17 09:17:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2250943002/20001
4 years, 4 months ago (2016-08-17 09:17:53 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-17 10:29:35 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 10:31:56 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/25cb7a2c691f668be41ea6ba5dcfe77313a9bd8a
Cr-Commit-Position: refs/heads/master@{#412487}

Powered by Google App Engine
This is Rietveld 408576698