Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 225093007: [Android]: Update Arm64 and x86_64 build targets to use the experimental ndk. (Closed)

Created:
6 years, 8 months ago by rmcilroy
Modified:
6 years, 8 months ago
CC:
chromium-reviews, primiano CORP (USE chromium), Anton
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Android]: Update Arm64 and x86_64 build targets to use the experimental ndk. BUG=354405, 346626 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262969

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Update to add android_ndk_experimental_root gyp variable. #

Patch Set 4 : Update stlport too. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -13 lines) Patch
M build/common.gypi View 1 2 3 4 chunks +9 lines, -12 lines 0 comments Download
M build/java_apk.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
rmcilroy
Primiano, could you take a look please?
6 years, 8 months ago (2014-04-04 14:31:20 UTC) #1
Primiano Tucci (use gerrit)
LGTM, as long as you wait that your other CL in android_tools for android-20 SDK ...
6 years, 8 months ago (2014-04-07 10:11:28 UTC) #2
rmcilroy
Modified a bit to work differently with regard to adding a seperate android_ndk_experimental_root. Could you ...
6 years, 8 months ago (2014-04-09 17:04:36 UTC) #3
Primiano Tucci (use gerrit)
On 2014/04/09 17:04:36, rmcilroy wrote: > Modified a bit to work differently with regard to ...
6 years, 8 months ago (2014-04-09 17:16:24 UTC) #4
rmcilroy
The CQ bit was checked by rmcilroy@chromium.org
6 years, 8 months ago (2014-04-10 07:12:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/225093007/60001
6 years, 8 months ago (2014-04-10 07:12:34 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 13:42:52 UTC) #7
Message was sent while issue was closed.
Change committed as 262969

Powered by Google App Engine
This is Rietveld 408576698