Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1065)

Unified Diff: src/x87/assembler-x87-inl.h

Issue 2250913002: [v8] Move all the RelocInfo::set_target_address function into one place. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Forget to modify assembler-arm64-inl.h Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/x64/assembler-x64-inl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/x87/assembler-x87-inl.h
diff --git a/src/x87/assembler-x87-inl.h b/src/x87/assembler-x87-inl.h
index 78177d3dce41ef34607b9cea0c9ceedb00ca1113..fa9b5a40d4cfcd0644b06612909b2d40546c4304 100644
--- a/src/x87/assembler-x87-inl.h
+++ b/src/x87/assembler-x87-inl.h
@@ -101,21 +101,6 @@ int RelocInfo::target_address_size() {
}
-void RelocInfo::set_target_address(Address target,
- WriteBarrierMode write_barrier_mode,
- ICacheFlushMode icache_flush_mode) {
- Assembler::set_target_address_at(isolate_, pc_, host_, target,
- icache_flush_mode);
- Assembler::set_target_address_at(isolate_, pc_, host_, target);
- DCHECK(IsCodeTarget(rmode_) || IsRuntimeEntry(rmode_));
- if (write_barrier_mode == UPDATE_WRITE_BARRIER && host() != NULL &&
- IsCodeTarget(rmode_)) {
- Object* target_code = Code::GetCodeFromTargetAddress(target);
- host()->GetHeap()->incremental_marking()->RecordWriteIntoCode(
- host(), this, HeapObject::cast(target_code));
- }
-}
-
Object* RelocInfo::target_object() {
DCHECK(IsCodeTarget(rmode_) || rmode_ == EMBEDDED_OBJECT);
return Memory::Object_at(pc_);
« no previous file with comments | « src/x64/assembler-x64-inl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698