Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: src/ia32/assembler-ia32-inl.h

Issue 2250913002: [v8] Move all the RelocInfo::set_target_address function into one place. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Forget to modify assembler-arm64-inl.h Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/assembler.cc ('k') | src/mips/assembler-mips-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 UNREACHABLE(); 94 UNREACHABLE();
95 return NULL; 95 return NULL;
96 } 96 }
97 97
98 98
99 int RelocInfo::target_address_size() { 99 int RelocInfo::target_address_size() {
100 return Assembler::kSpecialTargetSize; 100 return Assembler::kSpecialTargetSize;
101 } 101 }
102 102
103 103
104 void RelocInfo::set_target_address(Address target,
105 WriteBarrierMode write_barrier_mode,
106 ICacheFlushMode icache_flush_mode) {
107 Assembler::set_target_address_at(isolate_, pc_, host_, target,
108 icache_flush_mode);
109 DCHECK(IsCodeTarget(rmode_) || IsRuntimeEntry(rmode_));
110 if (write_barrier_mode == UPDATE_WRITE_BARRIER && host() != NULL &&
111 IsCodeTarget(rmode_)) {
112 Object* target_code = Code::GetCodeFromTargetAddress(target);
113 host()->GetHeap()->incremental_marking()->RecordWriteIntoCode(
114 host(), this, HeapObject::cast(target_code));
115 }
116 }
117
118 Object* RelocInfo::target_object() { 104 Object* RelocInfo::target_object() {
119 DCHECK(IsCodeTarget(rmode_) || rmode_ == EMBEDDED_OBJECT); 105 DCHECK(IsCodeTarget(rmode_) || rmode_ == EMBEDDED_OBJECT);
120 return Memory::Object_at(pc_); 106 return Memory::Object_at(pc_);
121 } 107 }
122 108
123 109
124 Handle<Object> RelocInfo::target_object_handle(Assembler* origin) { 110 Handle<Object> RelocInfo::target_object_handle(Assembler* origin) {
125 DCHECK(IsCodeTarget(rmode_) || rmode_ == EMBEDDED_OBJECT); 111 DCHECK(IsCodeTarget(rmode_) || rmode_ == EMBEDDED_OBJECT);
126 return Memory::Object_Handle_at(pc_); 112 return Memory::Object_Handle_at(pc_);
127 } 113 }
(...skipping 425 matching lines...) Expand 10 before | Expand all | Expand 10 after
553 539
554 Operand::Operand(Immediate imm) { 540 Operand::Operand(Immediate imm) {
555 // [disp/r] 541 // [disp/r]
556 set_modrm(0, ebp); 542 set_modrm(0, ebp);
557 set_dispr(imm.x_, imm.rmode_); 543 set_dispr(imm.x_, imm.rmode_);
558 } 544 }
559 } // namespace internal 545 } // namespace internal
560 } // namespace v8 546 } // namespace v8
561 547
562 #endif // V8_IA32_ASSEMBLER_IA32_INL_H_ 548 #endif // V8_IA32_ASSEMBLER_IA32_INL_H_
OLDNEW
« no previous file with comments | « src/assembler.cc ('k') | src/mips/assembler-mips-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698