Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 2250913002: [v8] Move all the RelocInfo::set_target_address function into one place. (Closed)

Created:
4 years, 4 months ago by Chen
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[v8] Move all the RelocInfo::set_target_address function into one place. BUG= Committed: https://crrev.com/3310b44e5331625ec836a8cb1fba9e383dd75948 Cr-Commit-Position: refs/heads/master@{#38693}

Patch Set 1 #

Patch Set 2 : Forget to modify assembler-arm64-inl.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -133 lines) Patch
M src/arm/assembler-arm-inl.h View 1 chunk +0 lines, -14 lines 0 comments Download
M src/arm64/assembler-arm64-inl.h View 1 1 chunk +0 lines, -15 lines 0 comments Download
M src/assembler.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/assembler.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M src/ia32/assembler-ia32-inl.h View 1 chunk +0 lines, -14 lines 0 comments Download
M src/mips/assembler-mips-inl.h View 1 chunk +0 lines, -14 lines 0 comments Download
M src/mips64/assembler-mips64-inl.h View 1 chunk +0 lines, -14 lines 0 comments Download
M src/ppc/assembler-ppc-inl.h View 1 chunk +0 lines, -15 lines 0 comments Download
M src/s390/assembler-s390-inl.h View 1 chunk +0 lines, -14 lines 0 comments Download
M src/x64/assembler-x64-inl.h View 1 chunk +0 lines, -14 lines 0 comments Download
M src/x87/assembler-x87-inl.h View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Chen
Hi Mircea, I made the change that moving all the RelocInfo::set_target_address into one place. Best, ...
4 years, 4 months ago (2016-08-17 02:36:55 UTC) #2
bradnelson
lgtm But also wait for mtrofin
4 years, 4 months ago (2016-08-17 17:34:13 UTC) #9
Mircea Trofin
On 2016/08/17 17:34:13, bradnelson wrote: > lgtm > But also wait for mtrofin lgtm
4 years, 4 months ago (2016-08-17 17:48:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2250913002/20001
4 years, 4 months ago (2016-08-17 17:54:27 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-17 17:56:28 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 17:56:52 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3310b44e5331625ec836a8cb1fba9e383dd75948
Cr-Commit-Position: refs/heads/master@{#38693}

Powered by Google App Engine
This is Rietveld 408576698