Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Unified Diff: chrome/browser/safe_browsing/ui_manager.cc

Issue 2250893002: Permission Action Reporting: Add num_prior_* fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@par-new-fields-proto
Patch Set: todo Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/safe_browsing/ui_manager.h ('k') | chrome/common/safe_browsing/permission_report.proto » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/ui_manager.cc
diff --git a/chrome/browser/safe_browsing/ui_manager.cc b/chrome/browser/safe_browsing/ui_manager.cc
index aa4ae691483aa3b217ed0306ee9655d8b20a6165..538b160f8dd9ce525221b1156e20d87fa37becb6 100644
--- a/chrome/browser/safe_browsing/ui_manager.cc
+++ b/chrome/browser/safe_browsing/ui_manager.cc
@@ -290,12 +290,15 @@ void SafeBrowsingUIManager::ReportPermissionAction(
content::PermissionType permission,
PermissionAction action,
PermissionSourceUI source_ui,
- PermissionRequestGestureType gesture_type) {
+ PermissionRequestGestureType gesture_type,
+ int num_prior_dismissals,
+ int num_prior_ignores) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
BrowserThread::PostTask(
BrowserThread::IO, FROM_HERE,
base::Bind(&SafeBrowsingUIManager::ReportPermissionActionOnIOThread, this,
- origin, permission, action, source_ui, gesture_type));
+ origin, permission, action, source_ui, gesture_type,
+ num_prior_dismissals, num_prior_ignores));
}
void SafeBrowsingUIManager::AddObserver(Observer* observer) {
@@ -325,7 +328,9 @@ void SafeBrowsingUIManager::ReportPermissionActionOnIOThread(
content::PermissionType permission,
PermissionAction action,
PermissionSourceUI source_ui,
- PermissionRequestGestureType gesture_type) {
+ PermissionRequestGestureType gesture_type,
+ int num_prior_dismissals,
+ int num_prior_ignores) {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
// The service may delete the ping manager (i.e. when user disabling service,
@@ -334,7 +339,8 @@ void SafeBrowsingUIManager::ReportPermissionActionOnIOThread(
return;
sb_service_->ping_manager()->ReportPermissionAction(
- origin, permission, action, source_ui, gesture_type);
+ origin, permission, action, source_ui, gesture_type, num_prior_dismissals,
+ num_prior_ignores);
}
// If the user had opted-in to send ThreatDetails, this gets called
« no previous file with comments | « chrome/browser/safe_browsing/ui_manager.h ('k') | chrome/common/safe_browsing/permission_report.proto » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698