chrome/browser/safe_browsing/ping_manager.h - Issue 2250893002: Permission Action Reporting: Add num_prior_* fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/ping_manager.h

Issue 2250893002: Permission Action Reporting: Add num_prior_* fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@par-new-fields-proto

Patch Set: todo Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/safe_browsing/ping_manager.h

diff --git a/chrome/browser/safe_browsing/ping_manager.h b/chrome/browser/safe_browsing/ping_manager.h

index 3a6c30c864acb84387d0aa919ebe78d757d111dd..5c4d6774e4e92d1ba903c2cabcc25a8cd0507bb9 100644

--- a/chrome/browser/safe_browsing/ping_manager.h

+++ b/chrome/browser/safe_browsing/ping_manager.h

@@ -70,7 +70,9 @@ class SafeBrowsingPingManager : public net::URLFetcherDelegate {

content::PermissionType permission,

PermissionAction action,

PermissionSourceUI source_ui,

- PermissionRequestGestureType gesture_type);

+ PermissionRequestGestureType gesture_type,

+ int num_prior_dismissals,

+ int num_prior_ignores);

private:

friend class PermissionReporterBrowserTest;

« no previous file with comments | « chrome/browser/safe_browsing/permission_reporter_unittest.cc ('k') | chrome/browser/safe_browsing/ping_manager.cc » ('j') | no next file with comments »