chrome/browser/permissions/permission_uma_util.cc - Issue 2250893002: Permission Action Reporting: Add num_prior_* fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/permission_uma_util.cc

Issue 2250893002: Permission Action Reporting: Add num_prior_* fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@par-new-fields-proto

Patch Set: Also update browsertest Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/permissions/permission_decision_auto_blocker.h ('K') | « chrome/browser/permissions/permission_decision_auto_blocker_unittest.cc ('k') | chrome/browser/safe_browsing/permission_reporter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/permissions/permission_uma_util.cc

diff --git a/chrome/browser/permissions/permission_uma_util.cc b/chrome/browser/permissions/permission_uma_util.cc

index 655473272778719ba00fab8762b592f73f5b7b98..32071098a3e13ce713fe8da1c769bedbe7ca5838 100644

--- a/chrome/browser/permissions/permission_uma_util.cc

+++ b/chrome/browser/permissions/permission_uma_util.cc

@@ -10,6 +10,7 @@

#include "base/metrics/histogram_macros.h"

#include "base/strings/stringprintf.h"

#include "chrome/browser/browser_process.h"

+#include "chrome/browser/permissions/permission_decision_auto_blocker.h"

#include "chrome/browser/permissions/permission_manager.h"

#include "chrome/browser/permissions/permission_request.h"

#include "chrome/browser/permissions/permission_util.h"

@@ -487,10 +488,13 @@ void PermissionUmaUtil::RecordPermissionAction(

const GURL& requesting_origin,

Profile* profile) {

if (IsOptedIntoPermissionActionReporting(profile)) {

+ PermissionDecisionAutoBlocker blocker(profile);

g_browser_process->safe_browsing_service()

->ui_manager()

->ReportPermissionAction(requesting_origin, permission, action,

- source_ui, gesture_type);

+ source_ui, gesture_type,

+ blocker.GetDismissCount(requesting_origin, permission),

+ blocker.GetIgnoreCount(requesting_origin, permission));

}

bool secure_origin = content::IsOriginSecure(requesting_origin);