Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: chrome/browser/permissions/permission_decision_auto_blocker.cc

Issue 2250893002: Permission Action Reporting: Add num_prior_* fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@par-new-fields-proto
Patch Set: Also update browsertest Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/permissions/permission_decision_auto_blocker.h" 5 #include "chrome/browser/permissions/permission_decision_auto_blocker.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/feature_list.h" 9 #include "base/feature_list.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 112
113 PermissionUmaUtil::PermissionPromptDismissed(permission, 113 PermissionUmaUtil::PermissionPromptDismissed(permission,
114 current_dismissal_count); 114 current_dismissal_count);
115 115
116 if (!base::FeatureList::IsEnabled(features::kBlockPromptsIfDismissedOften)) 116 if (!base::FeatureList::IsEnabled(features::kBlockPromptsIfDismissedOften))
117 return false; 117 return false;
118 118
119 return current_dismissal_count >= prompt_dismissals_before_block_; 119 return current_dismissal_count >= prompt_dismissals_before_block_;
120 } 120 }
121 121
122 int PermissionDecisionAutoBlocker::GetActionCountForTest( 122 int PermissionDecisionAutoBlocker::GetDismissCount(const GURL& url,
123 content::PermissionType permission) {
124 return GetActionCount(url, permission, kPromptDismissCountKey);
125 }
126
127 int PermissionDecisionAutoBlocker::GetIgnoreCount(const GURL& url,
128 content::PermissionType permission) {
129 return GetActionCount(url, permission, kPromptIgnoreCountKey);
130 }
131
132 int PermissionDecisionAutoBlocker::GetActionCount(
123 const GURL& url, 133 const GURL& url,
124 content::PermissionType permission, 134 content::PermissionType permission,
125 const char* key) { 135 const char* key) {
126 HostContentSettingsMap* map = 136 HostContentSettingsMap* map =
127 HostContentSettingsMapFactory::GetForProfile(profile_); 137 HostContentSettingsMapFactory::GetForProfile(profile_);
128 std::unique_ptr<base::DictionaryValue> dict = GetOriginDict(map, url); 138 std::unique_ptr<base::DictionaryValue> dict = GetOriginDict(map, url);
129 139
130 base::DictionaryValue* permission_dict = GetOrCreatePermissionDict( 140 base::DictionaryValue* permission_dict = GetOrCreatePermissionDict(
131 dict.get(), PermissionUtil::GetPermissionString(permission)); 141 dict.get(), PermissionUtil::GetPermissionString(permission));
132 142
(...skipping 26 matching lines...) Expand all
159 169
160 void PermissionDecisionAutoBlocker::UpdateFromVariations() { 170 void PermissionDecisionAutoBlocker::UpdateFromVariations() {
161 int prompt_dismissals = -1; 171 int prompt_dismissals = -1;
162 std::string value = variations::GetVariationParamValueByFeature( 172 std::string value = variations::GetVariationParamValueByFeature(
163 features::kBlockPromptsIfDismissedOften, kPromptDismissCountKey); 173 features::kBlockPromptsIfDismissedOften, kPromptDismissCountKey);
164 174
165 // If converting the value fails, stick with the default value. 175 // If converting the value fails, stick with the default value.
166 if (base::StringToInt(value, &prompt_dismissals) && prompt_dismissals > 0) 176 if (base::StringToInt(value, &prompt_dismissals) && prompt_dismissals > 0)
167 prompt_dismissals_before_block_ = prompt_dismissals; 177 prompt_dismissals_before_block_ = prompt_dismissals;
168 } 178 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698