Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2250873002: fix completion in switch case (Closed)

Created:
4 years, 4 months ago by danrubel
Modified:
4 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -25 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart/local_declaration_visitor.dart View 3 chunks +35 lines, -25 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
4 years, 4 months ago (2016-08-17 00:00:19 UTC) #2
Brian Wilkerson
lgtm
4 years, 4 months ago (2016-08-17 00:31:30 UTC) #3
danrubel
4 years, 4 months ago (2016-08-17 01:08:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d92849a8af4c52ff4d665663a8f1ce8825fbdc56 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698