Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2250863004: Fix machine types in GetRuntimeCallDescriptor (Closed)

Created:
4 years, 4 months ago by jgruber
Modified:
4 years, 4 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix machine types in GetRuntimeCallDescriptor The machine types were incorrect for the runtime function and argument count parameters. The latter was introduced in 3e2085eb, while the former seems to always have been wrong. This was not an issue so far because GetRuntimeCallDescriptor was only called after the representation selection phase and thus the machine type was ignored. R=jarin@chromium.org BUG= Committed: https://crrev.com/280fdf641169daac48f8273dddb8f7c85d9dd7be Cr-Commit-Position: refs/heads/master@{#38720}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/compiler/linkage.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
jgruber
4 years, 4 months ago (2016-08-18 12:51:58 UTC) #3
Jarin
lgtm
4 years, 4 months ago (2016-08-18 14:11:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2250863004/1
4 years, 4 months ago (2016-08-18 14:27:06 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 14:35:16 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 14:35:34 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/280fdf641169daac48f8273dddb8f7c85d9dd7be
Cr-Commit-Position: refs/heads/master@{#38720}

Powered by Google App Engine
This is Rietveld 408576698