exo: Run exo in mus+ash

exo: Run exo in mus+ash

Add WMHelperAsh and WMHelperMus. They are for accessing WM
related features in ash and mus+ash, and exo will create one
of those two helpers based on the WM environment.

Know issue: All methods of WMHelperMus are not implemented,
so the exo doesn't response to any events.

BUG=637914
TEST=manually with https://github.com/phuang/waylandcxx

Committed: https://crrev.com/608523d443e9a619abb5f8da7ed2dd7e08ba3f3c
Cr-Commit-Position: refs/heads/master@{#412861}

[Peng, 2016-08-17 15:42:09]

Description was changed from

==========
Run exo in mus+ash

BUG=
==========

to

==========
exo: Run exo in mus+ash


Add WMHelperAsh and WMHelperMus. They are for accessing WM
related features in ash and mus+ash, and exo will create one
of those two helper based on WM environment.

Know issue: Most methods of WMHelperMus are not implemented,
so the exo doesn't response to any events.


BUG=637914
==========

[Peng, 2016-08-17 15:42:51]

Description was changed from

==========
exo: Run exo in mus+ash


Add WMHelperAsh and WMHelperMus. They are for accessing WM
related features in ash and mus+ash, and exo will create one
of those two helper based on WM environment.

Know issue: Most methods of WMHelperMus are not implemented,
so the exo doesn't response to any events.


BUG=637914
==========

to

==========
exo: Run exo in mus+ash


Add WMHelperAsh and WMHelperMus. They are for accessing WM
related features in ash and mus+ash, and exo will create one
of those two helpers based on the WM environment.

Know issue: All methods of WMHelperMus are not implemented,
so the exo doesn't response to any events.


BUG=637914
==========

[Peng, 2016-08-17 15:43:15]

penghuang@chromium.org changed reviewers:
+ reveman@chromium.org

[Peng, 2016-08-17 15:43:16]

Hi David, Could you please take a look? Thanks.

[Peng, 2016-08-17 17:56:05]

Description was changed from

==========
exo: Run exo in mus+ash


Add WMHelperAsh and WMHelperMus. They are for accessing WM
related features in ash and mus+ash, and exo will create one
of those two helpers based on the WM environment.

Know issue: All methods of WMHelperMus are not implemented,
so the exo doesn't response to any events.


BUG=637914
==========

to

==========
exo: Run exo in mus+ash


Add WMHelperAsh and WMHelperMus. They are for accessing WM
related features in ash and mus+ash, and exo will create one
of those two helpers based on the WM environment.

Know issue: All methods of WMHelperMus are not implemented,
so the exo doesn't response to any events.


BUG=637914
TEST=manually with https://github.com/phuang/waylandcxx
==========

[reveman, 2016-08-17 20:01:41]

https://codereview.chromium.org/2250863003/diff/40001/components/exo/wm_helpe...
File components/exo/wm_helper.cc (right):

https://codereview.chromium.org/2250863003/diff/40001/components/exo/wm_helpe...
components/exo/wm_helper.cc:30: std::unique_ptr<WMHelper> WMHelper::Create(bool
using_mus) {
Can we add a "void SetInstance(WMHelper* helper)" function instead of this and
manage the lifetime of the instance in ChromeBrowserMainExtraPartsExo? ie.
create the appropriate instance there instead of having to pass a using_mus
flag.

[Peng, 2016-08-17 20:25:36]

https://codereview.chromium.org/2250863003/diff/40001/components/exo/wm_helpe...
File components/exo/wm_helper.cc (right):

https://codereview.chromium.org/2250863003/diff/40001/components/exo/wm_helpe...
components/exo/wm_helper.cc:30: std::unique_ptr<WMHelper> WMHelper::Create(bool
using_mus) {
On 2016/08/17 20:01:41, reveman wrote:
> Can we add a "void SetInstance(WMHelper* helper)" function instead of this and
> manage the lifetime of the instance in ChromeBrowserMainExtraPartsExo? ie.
> create the appropriate instance there instead of having to pass a using_mus
> flag.

Done.

[Peng, 2016-08-17 20:34:36]

The CQ bit was checked by penghuang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 20:35:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reveman, 2016-08-17 21:10:06]

lgtm with nits

https://codereview.chromium.org/2250863003/diff/60001/components/exo/display.cc
File components/exo/display.cc (right):

https://codereview.chromium.org/2250863003/diff/60001/components/exo/display....
components/exo/display.cc:21: #include "components/exo/wm_helper.h"
nit: remove if not needed

https://codereview.chromium.org/2250863003/diff/60001/components/exo/display.h
File components/exo/display.h (right):

https://codereview.chromium.org/2250863003/diff/60001/components/exo/display....
components/exo/display.h:34: class WMHelper;
nit: remove if not needed

https://codereview.chromium.org/2250863003/diff/60001/components/exo/wm_helpe...
File components/exo/wm_helper.cc (right):

https://codereview.chromium.org/2250863003/diff/60001/components/exo/wm_helpe...
components/exo/wm_helper.cc:23: DCHECK((helper && !g_instance) || (!helper &&
g_instance));
nit: DCHECK_NE(!!helper, !!g_instance)

https://codereview.chromium.org/2250863003/diff/60001/components/exo/wm_helpe...
File components/exo/wm_helper_ash.h (right):

https://codereview.chromium.org/2250863003/diff/60001/components/exo/wm_helpe...
components/exo/wm_helper_ash.h:27: private:
nit: please avoid overriding public virtual functions with private functions.
move "private: " to line 58.

https://codereview.chromium.org/2250863003/diff/60001/components/exo/wm_helpe...
File components/exo/wm_helper_mus.h (right):

https://codereview.chromium.org/2250863003/diff/60001/components/exo/wm_helpe...
components/exo/wm_helper_mus.h:19: private:
nit: please avoid overriding public virtual functions with private functions

[commit-bot: I haz the power, 2016-08-17 21:15:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 21:15:11]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Peng, 2016-08-17 21:17:17]

penghuang@chromium.org changed reviewers:
+ sky@chromium.org

[Peng, 2016-08-17 21:17:18]

+sky@ for chrome/*

Hi Scott, PTAL. Thanks.

[Peng, 2016-08-17 21:29:53]

The CQ bit was checked by penghuang@chromium.org to run a CQ dry run

[Peng, 2016-08-17 21:29:59]

https://codereview.chromium.org/2250863003/diff/60001/components/exo/display.cc
File components/exo/display.cc (right):

https://codereview.chromium.org/2250863003/diff/60001/components/exo/display....
components/exo/display.cc:21: #include "components/exo/wm_helper.h"
On 2016/08/17 21:10:05, reveman wrote:
> nit: remove if not needed

Done.

https://codereview.chromium.org/2250863003/diff/60001/components/exo/display.h
File components/exo/display.h (right):

https://codereview.chromium.org/2250863003/diff/60001/components/exo/display....
components/exo/display.h:34: class WMHelper;
On 2016/08/17 21:10:06, reveman wrote:
> nit: remove if not needed

Done.

https://codereview.chromium.org/2250863003/diff/60001/components/exo/wm_helpe...
File components/exo/wm_helper.cc (right):

https://codereview.chromium.org/2250863003/diff/60001/components/exo/wm_helpe...
components/exo/wm_helper.cc:23: DCHECK((helper && !g_instance) || (!helper &&
g_instance));
On 2016/08/17 21:10:06, reveman wrote:
> nit: DCHECK_NE(!!helper, !!g_instance)

Done.

https://codereview.chromium.org/2250863003/diff/60001/components/exo/wm_helpe...
File components/exo/wm_helper_ash.h (right):

https://codereview.chromium.org/2250863003/diff/60001/components/exo/wm_helpe...
components/exo/wm_helper_ash.h:27: private:
On 2016/08/17 21:10:06, reveman wrote:
> nit: please avoid overriding public virtual functions with private functions.
> move "private: " to line 58.

Done.

https://codereview.chromium.org/2250863003/diff/60001/components/exo/wm_helpe...
File components/exo/wm_helper_mus.h (right):

https://codereview.chromium.org/2250863003/diff/60001/components/exo/wm_helpe...
components/exo/wm_helper_mus.h:19: private:
On 2016/08/17 21:10:06, reveman wrote:
> nit: please avoid overriding public virtual functions with private functions

Done.

[commit-bot: I haz the power, 2016-08-17 21:30:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 22:08:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 22:08:07]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2016-08-17 23:30:40]

https://codereview.chromium.org/2250863003/diff/80001/chrome/browser/chrome_b...
File chrome/browser/chrome_browser_main_extra_parts_exo.cc (right):

https://codereview.chromium.org/2250863003/diff/80001/chrome/browser/chrome_b...
chrome/browser/chrome_browser_main_extra_parts_exo.cc:126: const bool using_mus
= !chrome::ShouldOpenAshOnStartup();
Can you use IsRunningInMash()? That seems to be what you care about.

[Peng, 2016-08-18 00:02:44]

https://codereview.chromium.org/2250863003/diff/80001/chrome/browser/chrome_b...
File chrome/browser/chrome_browser_main_extra_parts_exo.cc (right):

https://codereview.chromium.org/2250863003/diff/80001/chrome/browser/chrome_b...
chrome/browser/chrome_browser_main_extra_parts_exo.cc:126: const bool using_mus
= !chrome::ShouldOpenAshOnStartup();
On 2016/08/17 23:30:40, sky wrote:
> Can you use IsRunningInMash()? That seems to be what you care about.

Done.

[Peng, 2016-08-18 00:03:22]

The CQ bit was checked by penghuang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 00:04:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2016-08-18 00:08:03]

LGTM

[Peng, 2016-08-18 00:29:48]

The CQ bit was unchecked by penghuang@chromium.org

[Peng, 2016-08-18 00:30:01]

The CQ bit was checked by penghuang@chromium.org

[Peng, 2016-08-18 00:30:01]

The patchset sent to the CQ was uploaded after l-g-t-m from reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/2250863003/#ps100001
(title: "Fix review issue.")

[commit-bot: I haz the power, 2016-08-18 00:30:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 01:21:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 01:21:06]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Peng, 2016-08-18 01:42:15]

The CQ bit was checked by penghuang@chromium.org

[commit-bot: I haz the power, 2016-08-18 01:42:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 02:08:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 02:08:51]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Peng, 2016-08-18 14:31:23]

The CQ bit was checked by penghuang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 14:31:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 14:35:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 14:35:39]

Dry run: Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Peng, 2016-08-18 14:46:41]

The CQ bit was checked by penghuang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 14:46:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 15:30:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 15:30:43]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Peng, 2016-08-18 15:38:12]

The CQ bit was checked by penghuang@chromium.org

[Peng, 2016-08-18 15:38:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
reveman@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2250863003/#ps160001
(title: "Fix build errors")

[commit-bot: I haz the power, 2016-08-18 15:38:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 17:05:46]

Description was changed from

==========
exo: Run exo in mus+ash


Add WMHelperAsh and WMHelperMus. They are for accessing WM
related features in ash and mus+ash, and exo will create one
of those two helpers based on the WM environment.

Know issue: All methods of WMHelperMus are not implemented,
so the exo doesn't response to any events.


BUG=637914
TEST=manually with https://github.com/phuang/waylandcxx
==========

to

==========
exo: Run exo in mus+ash


Add WMHelperAsh and WMHelperMus. They are for accessing WM
related features in ash and mus+ash, and exo will create one
of those two helpers based on the WM environment.

Know issue: All methods of WMHelperMus are not implemented,
so the exo doesn't response to any events.


BUG=637914
TEST=manually with https://github.com/phuang/waylandcxx
==========

[commit-bot: I haz the power, 2016-08-18 17:05:47]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-08-18 17:10:18]

Description was changed from

==========
exo: Run exo in mus+ash


Add WMHelperAsh and WMHelperMus. They are for accessing WM
related features in ash and mus+ash, and exo will create one
of those two helpers based on the WM environment.

Know issue: All methods of WMHelperMus are not implemented,
so the exo doesn't response to any events.


BUG=637914
TEST=manually with https://github.com/phuang/waylandcxx
==========

to

==========
exo: Run exo in mus+ash

Add WMHelperAsh and WMHelperMus. They are for accessing WM
related features in ash and mus+ash, and exo will create one
of those two helpers based on the WM environment.

Know issue: All methods of WMHelperMus are not implemented,
so the exo doesn't response to any events.

BUG=637914
TEST=manually with https://github.com/phuang/waylandcxx

Committed: https://crrev.com/608523d443e9a619abb5f8da7ed2dd7e08ba3f3c
Cr-Commit-Position: refs/heads/master@{#412861}
==========

[commit-bot: I haz the power, 2016-08-18 17:10:20]

Patchset 9 (id:??) landed as
https://crrev.com/608523d443e9a619abb5f8da7ed2dd7e08ba3f3c
Cr-Commit-Position: refs/heads/master@{#412861}