Issue 2250863002: WIP: prototype ffi support (from 2084663004)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2250863002: WIP: prototype ffi support (from 2084663004)

Created:
4 years, 4 months ago by mattloring

Modified:
4 years ago

Reviewers:
ofrobots

CC:
v8-reviews_googlegroups.com, oth, rmcilroy, Yang

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

WIP: prototype ffi support (from 2084663004) BUG=

Patch Set 1 #

Patch Set 2 : Add ffi type enum #

Patch Set 3 : JSString to char* parameter conversion #

Patch Set 4 : Add v8 public api ffi #

Patch Set 5 : Support strings returned from C to JS #

Patch Set 6 : Support for TypedArrays as arguments #

Patch Set 7 : Bug fix for void functions #

Patch Set 8 : rebase #

Patch Set 9 : Add support for functions as FFI arguments #

Patch Set 10 : Rebase #

Patch Set 11 : Initial struct implementation without correct padding #

Patch Set 12 : Proper struct padding #

Patch Set 13 : Rebase #

Patch Set 14 : Support for opaque pointers #

Patch Set 15 : Fix to satisfy graph verifier, bind implementation #

Patch Set 16 : Initial implementation of correct JS entry from C #

Patch Set 17 : Support for passing arguments to async callbacks #

Patch Set 18 : Rebase #

Patch Set 19 : Translate callback signatures to remove hard coding #

Patch Set 20 : Clean up async arguments path #

Patch Set 21 : Support for bound arguments #

Patch Set 22 : Fix arguments interface for bound functions #

Patch Set 23 : Decoupled translation and invocation for async use #

Patch Set 24 : Public interface for serialization #

Patch Set 25 : Cache callback compilations + runtime cleanup #

Patch Set 26 : Rebase #

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2296 lines, -2 lines)			Patch
M	BUILD.gn	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25	3 chunks	+4 lines, -0 lines	0 comments	Download
A	include/v8-ffi.h	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23	1 chunk	+75 lines, -0 lines	0 comments	Download
M	src/DEPS	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25	1 chunk	+1 line, -1 line	0 comments	Download
A	src/compiler/ffi-compiler.h	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24	1 chunk	+153 lines, -0 lines	0 comments	Download
A	src/compiler/ffi-compiler.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24	1 chunk	+1237 lines, -0 lines	0 comments	Download
M	src/contexts.h	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/factory.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/log.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/objects.h	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/runtime/runtime.h	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25	2 chunks	+12 lines, -0 lines	0 comments	Download
A	src/runtime/runtime-ffi.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24	1 chunk	+267 lines, -0 lines	0 comments	Download
M	src/snapshot/code-serializer.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/v8.gyp	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25	3 chunks	+4 lines, -0 lines	0 comments	Download
M	test/cctest/BUILD.gn	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25	1 chunk	+1 line, -0 lines	0 comments	Download
M	test/cctest/cctest.gyp	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25	1 chunk	+1 line, -0 lines	0 comments	Download
A	test/cctest/test-ffi.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22	1 chunk	+531 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

mattloring

Description was changed from ========== WIP: prototype ffi support (from 2084663004) BUG= ========== to ========== ...

4 years, 4 months ago (2016-08-22 17:25:22 UTC) #1

mattloring

4 years, 4 months ago (2016-08-22 17:25:22 UTC) #2

mattloring@google.com changed reviewers:
+ ofrobots@google.com

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages